Android builds will permafail when Gecko 41 merges to Aurora

VERIFIED FIXED in Firefox 41

Status

()

Core
Memory Allocator
--
critical
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: RyanVM, Assigned: glandium)

Tracking

Trunk
mozilla41
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox41 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
https://treeherder.mozilla.org/logviewer.html#?job_id=8232265&repo=try

19:13:34 INFO - /builds/slave/try-and-api-9-0000000000000000/build/src/memory/mozjemalloc/jemalloc.c: In function 'malloc_init_hard':
19:13:34 INFO - Warning: -Wimplicit-function-declaration in /builds/slave/try-and-api-9-0000000000000000/build/src/memory/mozjemalloc/jemalloc.c: implicit declaration of function 'pthread_atfork'
19:13:34 INFO - /builds/slave/try-and-api-9-0000000000000000/build/src/memory/mozjemalloc/jemalloc.c:6045:2: warning: implicit declaration of function 'pthread_atfork' [-Wimplicit-function-declaration]
19:13:34 INFO - pthread_atfork(_malloc_prefork, _malloc_postfork, _malloc_postfork);
19:13:34 INFO - ^
19:13:34 INFO - /builds/slave/try-and-api-9-0000000000000000/build/src/memory/mozjemalloc/jemalloc.c: At top level:
19:13:34 INFO - /builds/slave/try-and-api-9-0000000000000000/build/src/memory/mozjemalloc/jemalloc.c:6519:1: error: conflicting types for 'malloc_usable_size'
19:13:34 INFO - malloc_usable_size_impl(void *ptr)
19:13:34 INFO - ^
19:13:34 INFO - In file included from ../../dist/system_wrappers/malloc.h:3:0,
19:13:34 INFO - from /builds/slave/try-and-api-9-0000000000000000/build/src/android-ndk/platforms/android-9/arch-arm/usr/include/string.h:33,
19:13:34 INFO - from ../../dist/system_wrappers/string.h:3,
19:13:34 INFO - from /builds/slave/try-and-api-9-0000000000000000/build/src/android-ndk/platforms/android-9/arch-arm/usr/include/stdlib.h:40,
19:13:34 INFO - from ../../dist/system_wrappers/stdlib.h:3,
19:13:34 INFO - from /builds/slave/try-and-api-9-0000000000000000/build/src/memory/mozjemalloc/jemalloc.c:213:
19:13:34 INFO - /builds/slave/try-and-api-9-0000000000000000/build/src/android-ndk/platforms/android-9/arch-arm/usr/include/malloc.h:36:15: note: previous declaration of 'malloc_usable_size' was here
19:13:34 INFO - extern size_t malloc_usable_size(const void*);
19:13:34 INFO - ^
19:13:34 INFO - gmake[5]: *** [jemalloc.o] Error 1
19:13:34 INFO - gmake[5]: Leaving directory `/builds/slave/try-and-api-9-0000000000000000/build/src/obj-firefox/memory/mozjemalloc'
19:13:34 INFO - gmake[4]: *** [memory/mozjemalloc/target] Error 2
Flags: needinfo?(mh+mozilla)
(Assignee)

Comment 1

3 years ago
Sigh. One more of those cases where changing NDK changes the bionic headers of old API levels...
Flags: needinfo?(mh+mozilla)
(Assignee)

Comment 2

3 years ago
Created attachment 8617027 [details] [diff] [review]
Don't guess malloc_usable_size type of argument based on ANDROID_VERSION in mozjemalloc, but use the result of the configure test instead
Assignee: nobody → mh+mozilla
Attachment #8617027 - Flags: review?(n.nethercote)
Comment on attachment 8617027 [details] [diff] [review]
Don't guess malloc_usable_size type of argument based on ANDROID_VERSION in mozjemalloc, but use the result of the configure test instead

Review of attachment 8617027 [details] [diff] [review]:
-----------------------------------------------------------------

Much better!
Attachment #8617027 - Flags: review?(n.nethercote) → review+
(Assignee)

Comment 4

3 years ago
.... and this breaks standalone js builds because the configure check is only in top-level. sigh.
(Assignee)

Comment 5

3 years ago
Created attachment 8617690 [details] [diff] [review]
Move some allocator related configure checks in a common location for both top-level and js/src to use
Attachment #8617690 - Flags: review?(mshal)
Comment on attachment 8617690 [details] [diff] [review]
Move some allocator related configure checks in a common location for both top-level and js/src to use

LGTM!
Attachment #8617690 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/46dde6cfd303
https://hg.mozilla.org/mozilla-central/rev/5c0acaf8f478
https://hg.mozilla.org/mozilla-central/rev/a1ea87558158
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(Reporter)

Updated

3 years ago
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
You need to log in before you can comment on or make changes to this bug.