Closed Bug 1172645 Opened 4 years ago Closed 4 years ago

Make mozbuild's setup.py work

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: gps, Assigned: gps)

Details

Attachments

(1 file)

As part of trying to integrate mozbuild's code into a separate project, I noticed that setup.py isn't up to date. We need to give it some love so we can release packages to PyPI.
Bug 1172645 - Make mozbuild's setup.py work

This file hasn't been updated in ages and the current configuration
doesn't produce working packages. Change that.
Attachment #8616878 - Flags: review?(mh+mozilla)
Comment on attachment 8616878 [details]
MozReview Request: Bug 1172645 - Make mozbuild's setup.py work; r?glandium

Bug 1172645 - Make mozbuild's setup.py work

This file hasn't been updated in ages and the current configuration
doesn't produce working packages. Change that.
Comment on attachment 8616878 [details]
MozReview Request: Bug 1172645 - Make mozbuild's setup.py work; r?glandium

https://reviewboard.mozilla.org/r/10489/#review9261

::: python/mozbuild/setup.py:10
(Diff revision 2)
> +MILESTONE = os.path.join(ROOT, 'config', 'milestone.txt')

This is kind of horrible, and I don't think we need to have a version for mozbuild that matches that of gecko.

::: python/mozbuild/setup.py:43
(Diff revision 2)
> +        'mozfile',

Aren't there more, like mozbase?

::: python/mozbuild/setup.py:46
(Diff revision 2)
> +        'Development Status :: 4 - Beta',

"3 - Alpha" seems more realistic

::: python/mozbuild/setup.py:49
(Diff revision 2)
> +        'Programming Language :: Python :: 2.7',

Not sure what "Programming Language :: Python :: Implementation :: CPython" is supposed to mean, but if it indicates the particular implementation we require, we should probably add it, because iirc, we rely on some CPython behavior for the sandbox.
Attachment #8616878 - Flags: review?(mh+mozilla)
https://reviewboard.mozilla.org/r/10489/#review9465

> Aren't there more, like mozbase?

Probably. But this is enough to ensure moz.build reading works :)
Comment on attachment 8616878 [details]
MozReview Request: Bug 1172645 - Make mozbuild's setup.py work; r?glandium

Bug 1172645 - Make mozbuild's setup.py work; r?glandium

This file hasn't been updated in ages and the current configuration
doesn't produce working packages. Change that.
Attachment #8616878 - Attachment description: MozReview Request: Bug 1172645 - Make mozbuild's setup.py work → MozReview Request: Bug 1172645 - Make mozbuild's setup.py work; r?glandium
Attachment #8616878 - Flags: review?(mh+mozilla)
Attachment #8616878 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8616878 [details]
MozReview Request: Bug 1172645 - Make mozbuild's setup.py work; r?glandium

https://reviewboard.mozilla.org/r/10489/#review9567

Ship It!

::: python/mozbuild/setup.py:7
(Diff revision 3)
> -VERSION = '0.1'
> +VERSION = '1.0'

1.0 for an alpha is a bit weird. Make it 0.2 ?
https://hg.mozilla.org/mozilla-central/rev/1068734a8ee8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.