Closed Bug 1172653 Opened 6 years ago Closed 6 years ago

browser_markupview_keybindings_02.js is going to permaleak when Gecko 41 merges to Aurora

Categories

(DevTools :: Inspector, defect)

defect
Not set
critical

Tracking

(firefox41 verified)

VERIFIED FIXED
Firefox 41
Tracking Status
firefox41 --- verified

People

(Reporter: RyanVM, Assigned: pbro)

Details

Attachments

(1 file)

I hit this on two different pushes, so looks legit.

https://treeherder.mozilla.org/logviewer.html#?job_id=8233504&repo=try

20:30:18 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/markupview/test/browser_markupview_keybindings_02.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul]
20:30:18 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/markupview/test/browser_markupview_keybindings_02.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/webconsole.xul]
20:30:18 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/markupview/test/browser_markupview_keybindings_02.js | leaked 1 window(s) until shutdown [url = about:blank]
Flags: needinfo?(pbrosset)
This test file was created in FF40 (in Aurora right now), and it does not fail there. So if it starts to fail with 41, something must have changed, but I can't understand why we're seeing this only when 41 merges to Aurora and not on m-c now. Are tests being run differently?
I can't see anything wrong in the logs, so I'll try and reproduce locally.
Flags: needinfo?(pbrosset)
I was able to reproduce locally, and found a one liner fix that really should have been here the whole time. I wonder why this doesn't leak on m-c.

r=me for this test-only change that prevents leaks when 41 merges in aurora.

Ryan, can you try this with your aurora-merge-simulation patch?
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Flags: needinfo?(ryanvm)
Attachment #8617269 - Flags: review+
Comment on attachment 8617269 [details] [diff] [review]
bug1172653-markupview-test-permafail-leak-on-auror.diff

Works perfectly!
Flags: needinfo?(ryanvm)
Attachment #8617269 - Flags: feedback+
https://hg.mozilla.org/mozilla-central/rev/0d73c1dde1f3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.