1172653 - browser_markupview_keybindings_02.js is going to permaleak when Gecko 41 merges to Aurora

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

I hit this on two different pushes, so looks legit.

https://treeherder.mozilla.org/logviewer.html#?job_id=8233504&repo=try

20:30:18 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/markupview/test/browser_markupview_keybindings_02.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul]
20:30:18 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/markupview/test/browser_markupview_keybindings_02.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/webconsole.xul]
20:30:18 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/markupview/test/browser_markupview_keybindings_02.js | leaked 1 window(s) until shutdown [url = about:blank]

Comment 1

[Patrick Brosset <:pbro>]

This test file was created in FF40 (in Aurora right now), and it does not fail there. So if it starts to fail with 41, something must have changed, but I can't understand why we're seeing this only when 41 merges to Aurora and not on m-c now. Are tests being run differently?
I can't see anything wrong in the logs, so I'll try and reproduce locally.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: bug1172653-markupview-test-permafail-leak-on-auror.diff

I was able to reproduce locally, and found a one liner fix that really should have been here the whole time. I wonder why this doesn't leak on m-c.

r=me for this test-only change that prevents leaks when 41 merges in aurora.

Ryan, can you try this with your aurora-merge-simulation patch?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8617269 [details] [diff] [review]
bug1172653-markupview-test-permafail-leak-on-auror.diff

Works perfectly!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0d73c1dde1f3

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0d73c1dde1f3