browser_markupview_keybindings_02.js is going to permaleak when Gecko 41 merges to Aurora

VERIFIED FIXED in Firefox 41

Status

()

Firefox
Developer Tools: Inspector
--
critical
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: RyanVM, Assigned: pbro)

Tracking

unspecified
Firefox 41
Points:
---

Firefox Tracking Flags

(firefox41 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
I hit this on two different pushes, so looks legit.

https://treeherder.mozilla.org/logviewer.html#?job_id=8233504&repo=try

20:30:18 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/markupview/test/browser_markupview_keybindings_02.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul]
20:30:18 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/markupview/test/browser_markupview_keybindings_02.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/webconsole.xul]
20:30:18 WARNING - TEST-UNEXPECTED-FAIL | browser/devtools/markupview/test/browser_markupview_keybindings_02.js | leaked 1 window(s) until shutdown [url = about:blank]
Flags: needinfo?(pbrosset)
(Assignee)

Comment 1

3 years ago
This test file was created in FF40 (in Aurora right now), and it does not fail there. So if it starts to fail with 41, something must have changed, but I can't understand why we're seeing this only when 41 merges to Aurora and not on m-c now. Are tests being run differently?
I can't see anything wrong in the logs, so I'll try and reproduce locally.
Flags: needinfo?(pbrosset)
(Assignee)

Comment 2

3 years ago
Created attachment 8617269 [details] [diff] [review]
bug1172653-markupview-test-permafail-leak-on-auror.diff

I was able to reproduce locally, and found a one liner fix that really should have been here the whole time. I wonder why this doesn't leak on m-c.

r=me for this test-only change that prevents leaks when 41 merges in aurora.

Ryan, can you try this with your aurora-merge-simulation patch?
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Flags: needinfo?(ryanvm)
Attachment #8617269 - Flags: review+
(Reporter)

Comment 3

3 years ago
Comment on attachment 8617269 [details] [diff] [review]
bug1172653-markupview-test-permafail-leak-on-auror.diff

Works perfectly!
Flags: needinfo?(ryanvm)
Attachment #8617269 - Flags: feedback+
https://hg.mozilla.org/mozilla-central/rev/0d73c1dde1f3
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
(Reporter)

Updated

3 years ago
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
You need to log in before you can comment on or make changes to this bug.