Closed Bug 1172657 Opened 6 years ago Closed 6 years ago

Work around a llvm bug by skipping the inline assembly in ToInt32 on arm-darwin (iOS)

Categories

(Core :: JavaScript Engine, defect)

Unspecified
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: ted, Assigned: ted)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The inline assembly in ToInt32 crashes Apple's clang. jrmuizel was able to reproduce this and reduce a testcase and he filed it upstream with LLVM: https://llvm.org/bugs/show_bug.cgi?id=22974
bug 1172657 - ToInt32's arm asm crashes Apple clang, so #ifdef around the assembly for now. r?waldo
Attachment #8622424 - Flags: review?(jwalden+bmo)
Comment on attachment 8622424 [details]
MozReview Request: bug 1172657 - ToInt32's arm asm crashes Apple clang, so #ifdef around the assembly for now. r?waldo

https://reviewboard.mozilla.org/r/11349/#review9761

::: js/public/Conversions.h:352
(Diff revision 1)
> -#if defined (__arm__) && defined (__GNUC__)
> +#if defined (__arm__) && defined (__GNUC__) && !defined(__APPLE__)

Add a comment explaining why Apple is being excluded here, please.
Attachment #8622424 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/1affb4e7d334
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.