Work around a llvm bug by skipping the inline assembly in ToInt32 on arm-darwin (iOS)

RESOLVED FIXED in Firefox 42

Status

()

Core
JavaScript Engine
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

(Blocks: 1 bug)

unspecified
mozilla42
Unspecified
iOS
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The inline assembly in ToInt32 crashes Apple's clang. jrmuizel was able to reproduce this and reduce a testcase and he filed it upstream with LLVM: https://llvm.org/bugs/show_bug.cgi?id=22974
(Assignee)

Comment 1

2 years ago
Created attachment 8622424 [details]
MozReview Request: bug 1172657 - ToInt32's arm asm crashes Apple clang, so #ifdef around the assembly for now. r?waldo

bug 1172657 - ToInt32's arm asm crashes Apple clang, so #ifdef around the assembly for now. r?waldo
Attachment #8622424 - Flags: review?(jwalden+bmo)
Comment on attachment 8622424 [details]
MozReview Request: bug 1172657 - ToInt32's arm asm crashes Apple clang, so #ifdef around the assembly for now. r?waldo

https://reviewboard.mozilla.org/r/11349/#review9761

::: js/public/Conversions.h:352
(Diff revision 1)
> -#if defined (__arm__) && defined (__GNUC__)
> +#if defined (__arm__) && defined (__GNUC__) && !defined(__APPLE__)

Add a comment explaining why Apple is being excluded here, please.
Attachment #8622424 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1affb4e7d334
https://hg.mozilla.org/mozilla-central/rev/1affb4e7d334
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.