Push implementation generates new build warnings

RESOLVED FIXED in Firefox 41

Status

()

Core
DOM: Push Notifications
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mt, Assigned: dragana)

Tracking

unspecified
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
This might be indicative of a problem, but more likely it's just a case of excessive spam.

 0:21.56 /home/martin/code/gecko-dev/dom/push/PushDB.jsm: WARNING: no preprocessor directives found
 0:21.62 /home/martin/code/gecko-dev/dom/push/PushService.jsm: WARNING: no preprocessor directives found
 0:21.66 /home/martin/code/gecko-dev/dom/push/PushServiceHttp2.jsm: WARNING: no preprocessor directives found

Comment 1

3 years ago
https://dxr.mozilla.org/mozilla-central/source/dom/push/moz.build#12

Can we move these jsm files to a new "EXTRA_JS_MODULES" declaration?
Flags: needinfo?(dd.mozilla)
(Assignee)

Comment 2

3 years ago
Created attachment 8617212 [details] [diff] [review]
bug_1172667_v1.patch
Flags: needinfo?(dd.mozilla)
Attachment #8617212 - Flags: review?(dougt)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8617212 [details] [diff] [review]
bug_1172667_v1.patch

I'll save doug the trouble.
Attachment #8617212 - Flags: review?(dougt) → review+
(Assignee)

Updated

3 years ago
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ad4a320aaa99
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.