Closed
Bug 1172682
Opened 9 years ago
Closed 9 years ago
Comment and refactor analysis code
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
10.00 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
Every time I go back over this code, I find things that are outright lies (in comments and function names). I stared hard enough at it this time that I'm *pretty* sure I understand what's going on here. For sure. Honest.
|
Assignee | |
Comment 1•9 years ago
|
||
The one change this patch makes in functionality is that it properly computes minimumUse in more cases, in anticipation of it being used for hazards (in addition to its current use for unnecessary roots). Though it's no longer looking like using minimumUse is even necessary in the case I was trying to fix. So I'm just going to land this for the comment changes, and see if the mystery hazard returns.
Attachment #8616920 -
Flags: review?(terrence)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8616920 [details] [diff] [review] Comment and refactor analysis code Review of attachment 8616920 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8616920 -
Flags: review?(terrence) → review+
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b22c5f882aea
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•