1172692 - Homescreen edit mode (from long-pressing app icon) now has unstyled text for "Edit" title & "Done" link

Status: RESOLVED DUPLICATE of bug 1154055

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot

STR:
 Long-press an app icon on your desktop.

ACTUAL RESULTS:
Text labels "Edit" & "Done" appear at the upper-left of your desktop, as you enter edit mode. They overlap app icons. See attached screenshot.

EXPECTED RESULTS:
This text should be styled more cleanly (as a title & button I think?)


This is with latest Firefox OS 3.0 dogfood OTA update on my Xperia Z3C

Build ID: 20150608110222

Comment 1

[Daniel Holbert [:dholbert]]

I see this in adb logcat when entering edit mode -- may be related:
06-08 15:17:56.626 E/Homescreen( 1211): [JavaScript Error: "TypeError: this.app.getLocalizedValue is not a function" {file: "app://verticalhome.gaiamobile.org/gaia_build_defer_index.js" line: 561}]

Comment 2

[Daniel Holbert [:dholbert]]

Also, starting today (I think), I only see the first 2 (of 5) rows of my own installed apps after my phone starts up. The 3rd, 4th, & 5th rows only show up after I've entered "homescreen edit mode". And for some reason, there's a blank space (broken app?) on my 3rd row of apps (this is the first row that's missing at bootup time).

I suspect this may all be related (i.e. maybe something is falling over when processing that broken blank-space app, perhaps?)

Comment 3

[Doug Sherk (:drs) (inactive)]

QA:
1. Does this happen on Flame? (speculation: probably)
2. If so, does it happen on a Flame with 2.2 on it?

Please needinfo me when investigation is complete. Thanks.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: screenshot of my homescreen, showing where scrolling ends at startup & missing app icon

Here's a screenshot illustrating comment 2. (which may or may not be related to comment 0 / comment 1.)

Comment 5

[Daniel Holbert [:dholbert]]

I caught the comment 1 JS error with a breakpoint (where we hit gaia_build_defer_index.js line 561 with this.app being truthy but this.app.getLocalizedValue being falsey).

It seems to be for an app whose name is "Sechelt", which I think is MozVR based on http://sechelt.fxosapps.org/images/icon.png (which is definitely not the missing icon shown in my last screenshot).

Comment 6

[Daniel Holbert [:dholbert]]

(Actually, I seem to trigger comment 1's JS error with a different random app each time I reload the homescreen app. Anyway, I'll stop poking at this & let any gaia/homescreen experts take it from here, since that part at least doesn't seem to be dependent on my weird broken-app system state.)

Comment 7

[Doug Sherk (:drs) (inactive)]

We cut Sechelt from the build in bug 1171164. Previously, we thought that removing apps from the build wouldn't cause any problems for people, but it seems that may have been the root cause here.

Kevin, Chris, is there a way that we can prevent rendering apps on the Homescreen that have been removed?

Comment 8

[Daniel Holbert [:dholbert]]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #3)
> 1. Does this happen on Flame? (speculation: probably)

I can't repro on my flame, with latest-mozilla-central-flame-kk gecko & gaia flashed onto it. Build ID 20150608010204

> 2. If so, does it happen on a Flame with 2.2 on it?

(N/A)

Comment 9

[Brogan Zumwalt [Inactive]]

Unable to reproduce the original issue stated in comment 0 on latest Spark 3.0 debug and dogfood-debug builds or on Flame 2.2

After long pressing any app on homescreen the "edit" and "done" elements show as a centered header title and a text button on the right side of the header respectively.

Daniel could you post more information on what build you are using like the environmental variables?

Device: Aries 3.0 (debug)
Build ID: 20150608202903
Gaia: 92ce25e46faf3d3c66aa884759ff84ede039f71d
Gecko: e10e2e8d8bf2
Gonk: 3af1ede0d0956cfbf9c549df7cd9a6807a9efdf2
Version: 41.0a1 (3.0)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Device: Aries 3.0 (dogfood_debug)
Build ID: 20150608200123
Gaia: 42e2ca3289fffa227924149b307c4c27e0503809
Gecko: e10e2e8d8bf2
Gonk: 3af1ede0d0956cfbf9c549df7cd9a6807a9efdf2
Version: 41.0a1 (3.0)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Device: Flame 2.2
Build ID: 20150608002505
Gaia: 8fc797527a3eca7665bc1d1828848f2fb77ca99f
Gecko: d213237e11e9
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 10

[Daniel Holbert [:dholbert]]

(In reply to Brogan Zumwalt [:BroganZ] from comment #9)
> Daniel could you post more information on what build you are using like the
> environmental variables?

I'm using the Spark dogfooding build for the Aries device. Not sure which environmental variables you're asking about -- I didn't compile the OS myself, so I don't know the environmental variables used. (and I haven't manually set any environmental variables on the device)

Comment 11

[Daniel Holbert [:dholbert]]

(Let me know if there's a script I can run to dump output like you posted in comment 9)

Comment 12

[Kevin Grandon :kgrandon]

Hmm, we are supposed to handle this ok, I will take a look but not sure when I can commit to getting this done.

Looks like there is some over-complicated sync logic here: https://github.com/mozilla-b2g/gaia/blob/master/apps/verticalhome/js/sources/application.js#L166

How did this device get flashed/updated? Is there a STR?

Comment 13

[Daniel Holbert [:dholbert]]

I flashed it myself (just over a week ago), using the steps in the dogfooding google doc.  I've gotten OTA updates every few days.

I've had one failed app update which caused some issues (bug 1171709) and I've noticed empty spaces in my app icon grid before (didn't get around to filing); that may or may not be related to this.

I don't have STR from scratch, but this is just happening 100% of the time that I enter homescreen edit mode, on my dogfooding phone.

kgrandon, are you going to be in either MV or SF office tomorrow?  I see your bugzilla nick says PTO, so I suspect not; but if so, I'm happy to head to whichever office you're in & loan you my phone for a bit so you can poke around. (Also: feel free to deputize someone else local to take a look at this.)

Comment 14

[Daniel Holbert [:dholbert]]

(This issue persists after a reboot, too, BTW.)

Comment 15

[Kevin Grandon :kgrandon]

I'm on PTO, but might try to make it into MTV sometime next week to take a look at your phone - it would be very good to get this solved pre-whistler if possible. Thanks for offering up your phone to debug on :)

Comment 16

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #11)
> (Let me know if there's a script I can run to dump output like you posted in
> comment 9)

check_versions.py from the B2G-flash-tool repo gives me the following output, FWIW:

Build ID               20150608110222
Gaia Revision          592b6cf0ffc7f487b0c52a8a74ce8ac389a593c6
Gaia Date              2015-06-08 10:08:59
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4700d1cdf489
Gecko Version          41.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150528.204812
Firmware Date          Thu May 28 20:48:20 UTC 2015
Bootloader             s1

Comment 17

[Chris Lord [:cwiiis]]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> I see this in adb logcat when entering edit mode -- may be related:
> 06-08 15:17:56.626 E/Homescreen( 1211): [JavaScript Error: "TypeError:
> this.app.getLocalizedValue is not a function" {file:
> "app://verticalhome.gaiamobile.org/gaia_build_defer_index.js" line: 561}]

Is this happening because the app has been uninstalled? If it has, why is the app still in the homescreen? Seems like we should be able to handle this easily enough, leaving n?me to look into it if no one gets there before me.

Comment 18

[Brogan Zumwalt [Inactive]]

Thanks Daniel, I am still getting used to the switch from PVT to Taskcluster and just wanted to make sure I was checking a later build than yours. Since I can't repro I am leaving qawanted to see if someone else can reproduce.

Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/592b6cf0ffc7f487b0c52a8a74ce8ac389a593c6...42e2ca3289fffa227924149b307c4c27e0503809

Gecko pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4700d1cdf489&tochange=e10e2e8d8bf2

Comment 20

[Daniel Holbert [:dholbert]]

[dropping "wanted" keywords, as this turned out to be a dupe of an older bug]