GetSubresourceURI should properly compute the resource path

RESOLVED FIXED in Firefox 43

Status

()

Core
Networking
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: valentin, Assigned: valentin)

Tracking

41 Branch
mozilla43
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox41 affected, firefox43 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Currently, the resource path is simply appended to the package path.
We should make sure the path is normalized, and that it can't escape the package's namespace.
(Assignee)

Comment 1

2 years ago
Created attachment 8646110 [details] [diff] [review]
Make GetSubresourceURI normalize the path for packaged resources
Attachment #8646110 - Flags: review?(mcmanus)
Comment on attachment 8646110 [details] [diff] [review]
Make GetSubresourceURI normalize the path for packaged resources

Review of attachment 8646110 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/PackagedAppService.cpp
@@ +337,5 @@
> +  {
> +    // We use this temp URI to generate a path that is relative
> +    // to the package URI and not to the root of the domain.
> +    nsCOMPtr<nsIURI> tempURI;
> +    NS_NewURI(getter_AddRefs(tempURI), "http://temp-domain/");

temp-domain.local - jic
Attachment #8646110 - Flags: review?(mcmanus) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/846e76b0e711
https://hg.mozilla.org/mozilla-central/rev/846e76b0e711
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.