1172722 - [Aries][Music][Share Activity] Music share activity opens as a blank list with broken UI.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-music-share.txt

Description:
When the user loads the music select list as a share activity from Email or Messages, the device will show a mostly dark screen, with a scroll bar on the side, but no listed songs.  The back (<) arrow in the top left corner is also non-functional when this occurs.

Repro Steps:
1) Update a Aries to 20150608110222
2) Ensure there are songs initialized on the device by opening the music app.
3) Launch the messages app and compose a new message.
4) Tap the Attach (paperclip) icon and select Music.

Actual:
An empty list with non-functional UI will load.

Expected:
A functional list of music found on the device loads.

Environmental Variables:
Device: Aries 3.0 (Full Flash)
Build ID: 20150608110222
Gaia: 592b6cf0ffc7f487b0c52a8a74ce8ac389a593c6
Gecko: 4700d1cdf489
Gonk: 3af1ede0d0956cfbf9c549df7cd9a6807a9efdf2
Version: 41.0a1 (3.0)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Repro frequency: 6/9
See attached: Video (URL), Logcat

===========================================

This issue does NOT occur on Flame 3.0 builds
A functional list of music found on the device loads.

Environmental Variables:
Device: Flame 3.0 (Full Flash)
Build ID: 20150608010204
Gaia: 1d62b32408567f9f7cf1c71c1e5a0c6593be757b
Gecko: 7d4ab4a9febd
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 41.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Comment 1

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Broken functionality

Comment 2

[Justin D'Arcangelo [:justindarc]]

Jim, can you take a look at this?

Comment 3

[Jim Porter (:squib)]

It's a race condition, but it's going to be a pain to fix. I have some ideas, but I think I want to land some preliminary patches to make my life easier first.

Comment 4

[Jim Porter (:squib)]

Attachment: Fix it

This should fix it. Waiting on green tests to be sure before I ask for review, though...

Comment 6

[Dominic Kuo [:dkuo]]

Comment on attachment 8622823 [details] [review]
Fix it

Jim, thanks for addressing this issue, the patch looks good to me and should fix the race condition, though I didn't encounter it while making those refatoring changes. There is a minor issue on github and please take a look before landing this.

Comment 7

[Jim Porter (:squib)]

Landed: https://github.com/mozilla-b2g/gaia/commit/90982230da9fa91d5185c0a8c7eca8e3e4d7df7f

Comment 8

[Jessica]

Attachment: verified_Aries v2.5.3gp

According to the STR of Comment 0, this bug has been verified as pass on latest Aries 2.5.

Actual results: A functional list of music could be found.

See attachment: verified_Aries v2.5.3gp
Reproduce rate: 0/6

Device: Aries KK 2.5(Pass)
Build ID               20150803195455
Gaia Revision          dbacf8364f4505d021b7d8fb9cabea325004dbcc
Gaia Date              2015-08-03 16:38:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/abc56d57f6e1
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150803.191800
Firmware Date          Mon Aug  3 19:18:08 UTC 2015
Bootloader             s1