1172761 - Remove two uses of PL_DHashTableEnumerate() from XPCOM

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

Because PLDHashTable::Iterator is much nicer than PL_DHashTableEnumerate().

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove PL_DHashTableEnumerator use from nsAtomTable

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove PL_DHashTableEnumerator use from nsPersistentProperties

BTW, is the raw |nsPropertyElement*| kosher or should it be
|nsRefPtr<nsPropertyElement>|?

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove PL_DHashTableEnumerator use from nsAtomTable

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove PL_DHashTableEnumerator use from nsPersistentProperties

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8617157 [details] [diff] [review]
(part 2) - Remove PL_DHashTableEnumerator use from nsPersistentProperties

Review of attachment 8617157 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/ds/nsPersistentProperties.cpp
@@ +577,5 @@
> +    auto entry = static_cast<PropertyTableEntry*>(iter.NextEntry());
> +
> +    nsPropertyElement* element =
> +      new nsPropertyElement(nsDependentCString(entry->mKey),
> +                            nsDependentString(entry->mValue));

Making this nsRefPtr<nsPropertyElement> would be good so that in the unlikely event that AppendObject fails, the nsPropertyElement doesn't leak.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7e2543f579e
https://hg.mozilla.org/integration/mozilla-inbound/rev/81073a8fcb41

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a7e2543f579e
https://hg.mozilla.org/mozilla-central/rev/81073a8fcb41