Closed Bug 1172784 Opened 4 years ago Closed 4 years ago

Remove PL_DHashTableEnumerate() use from nsContentUtils

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(2 files, 1 obsolete file)

Because PLDHashTable::Iterate is nicer than PL_DHashTableEnumerate().
This is possible because ListenerEnumerator() doesn't do anything with the
|aArg| argument.
Attachment #8617091 - Flags: review?(amarchesini)
Comment on attachment 8617091 [details] [diff] [review]
(part 1) - Remove unused argument from UnmarkGrayJSListenersInCCGenerationDocuments()

Review of attachment 8617091 [details] [diff] [review]:
-----------------------------------------------------------------

Weird. Looks like this was just some cruft that Olli and I missed at the initial landing. (This is CC-specific stuff, so I can review it.)
Attachment #8617091 - Flags: review?(amarchesini) → review+
(I can also review any other patches you have that touch these methods.)
Thank you for the fast reviews.
Attachment #8617112 - Flags: review?(continuation)
Attachment #8617112 - Attachment is obsolete: true
Attachment #8617112 - Flags: review?(continuation)
Comment on attachment 8617159 [details] [diff] [review]
(part 2) - Remove PL_DHashTableEnumerate use from nsContentUtils

Review of attachment 8617159 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsContentUtils.cpp
@@ +3985,4 @@
>  void
>  nsContentUtils::UnmarkGrayJSListenersInCCGenerationDocuments()
>  {
>    if (sEventListenerManagersHash) {

maybe start this method out with an early return off !sEventListenerManagersHash.
Attachment #8617159 - Flags: review?(continuation) → review+
https://hg.mozilla.org/mozilla-central/rev/fe8c95f78cfa
https://hg.mozilla.org/mozilla-central/rev/c41551d4219f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.