1172784 - Remove PL_DHashTableEnumerate() use from nsContentUtils

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nicholas Nethercote [inactive]]

Because PLDHashTable::Iterate is nicer than PL_DHashTableEnumerate().

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove unused argument from UnmarkGrayJSListenersInCCGenerationDocuments()

This is possible because ListenerEnumerator() doesn't do anything with the
|aArg| argument.

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 8617091 [details] [diff] [review]
(part 1) - Remove unused argument from UnmarkGrayJSListenersInCCGenerationDocuments()

Review of attachment 8617091 [details] [diff] [review]:
-----------------------------------------------------------------

Weird. Looks like this was just some cruft that Olli and I missed at the initial landing. (This is CC-specific stuff, so I can review it.)

Comment 3

[Andrew McCreight [:mccr8]]

(I can also review any other patches you have that touch these methods.)

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove PL_DHashTableEnumerate use from nsContentUtils

Thank you for the fast reviews.

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove PL_DHashTableEnumerate use from nsContentUtils

Comment 6

[Andrew McCreight [:mccr8]]

Comment on attachment 8617159 [details] [diff] [review]
(part 2) - Remove PL_DHashTableEnumerate use from nsContentUtils

Review of attachment 8617159 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsContentUtils.cpp
@@ +3985,4 @@
>  void
>  nsContentUtils::UnmarkGrayJSListenersInCCGenerationDocuments()
>  {
>    if (sEventListenerManagersHash) {

maybe start this method out with an early return off !sEventListenerManagersHash.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe8c95f78cfa
https://hg.mozilla.org/integration/mozilla-inbound/rev/c41551d4219f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fe8c95f78cfa
https://hg.mozilla.org/mozilla-central/rev/c41551d4219f