1172813 - profile-symbolicate.py fails with "ValueError: invalid literal for int() with base 0"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Ting-Yu Chou [:ting] (away)]

Signaling Profiled Processes: 204 1530
Stabilizing 204 b2g ...
Pulling /data/local/tmp/profile_0_204.txt into profile_204_b2g.txt
Adding symbols to profile_204_b2g.txt and creating profile_204_b2g.sym ...
Traceback (most recent call last):
  File "./scripts/profile-symbolicate.py", line 489, in <module>
    main()
  File "./scripts/profile-symbolicate.py", line 470, in main
    libs.SearchUnresolvedAddresses(progress=progress)
  File "./scripts/profile-symbolicate.py", line 392, in SearchUnresolvedAddresses
    for address in addresses:
  File "./scripts/profile-symbolicate.py", line 371, in getUnresolvedAddressesV3
    yield int(str, 0)
ValueError: invalid literal for int() with base 0: '0xb303c7b0 replacing unconfirmed target 0xab182200 with real target 0xa9ddff00 '

Comment 1

[Ting-Yu Chou [:ting] (away)]

Attachment: patch v1

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 8617186 [details] [review]
patch v1

Do you have an example of a string which causes the int conversion to fail? I mean an example from the file we're parsing, Obviously strings like 0xz would fail. But where are these bad strings coming from?

I think that the patch is fine, I'm just surprised.

Comment 3

[Ting-Yu Chou [:ting] (away)]

(In reply to Dave Hylands [:dhylands] from comment #2)
> Do you have an example of a string which causes the int conversion to fail?
> I mean an example from the file we're parsing, Obviously strings like 0xz
> would fail. But where are these bad strings coming from?

It's there in the exception: '0xb303c7b0 replacing unconfirmed target 0xab182200 with real target 0xa9ddff00 ', from https://dxr.mozilla.org/mozilla-central/source/gfx/layers/apz/src/InputBlockState.cpp#50.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/B2G/commit/d183e4ae815e530aaeb2c4fc2b05095ddef6b272