Closed Bug 1172824 Opened 5 years ago Closed 5 years ago

Fix a few Coverity issues in the JS engine

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

Details

(Whiteboard: [CID 1302587][CID 1304705][CID 1304706])

Attachments

(3 files)

No description provided.
Attached patch 1.patchSplinter Review
Attachment #8617201 - Flags: review?(jcoppeard)
Attached patch 2.patchSplinter Review
Attachment #8617202 - Flags: review?(terrence)
Attached patch 3.patchSplinter Review
Attachment #8617203 - Flags: review?(terrence)
Actually there are quite a few issues with uninitialized members, but they don't seem to matter much: for most of these structures, the callers have a total control of all members. Might be good mentored bugs, though..
Status: NEW → ASSIGNED
Whiteboard: [CID 1302587][CID 1304705][CID 1304706]
Attachment #8617201 - Flags: review?(jcoppeard) → review+
Attachment #8617202 - Flags: review?(terrence) → review+
Comment on attachment 8617203 [details] [diff] [review]
3.patch

Review of attachment 8617203 [details] [diff] [review]:
-----------------------------------------------------------------

And quite a few compiler warning about uninitialized members as well.
Attachment #8617203 - Flags: review?(terrence) → review+
Thanks for the reviews! I'll wait for the trees to reopen...
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf7dad4ddbdb
You need to log in before you can comment on or make changes to this bug.