Closed Bug 1172826 Opened 9 years ago Closed 9 years ago

Clean up MediaDecoderStateMachine::mPlaybackRate

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(1 file)

1172826_cleanup_mPlaybackRate-v1.patch
3.18 KB, patch
kinetik
: review+
Details | Diff | Splinter Review 
MediaDecoderStateMachine::LogicalPlaybackRateChanged will never set zero to mPlaybackRate. We can remove unnecessary checks for mPlaybackRate.
Assignee: nobody → jwwang
Status: NEW → ASSIGNED

        Attachment #8622867 -
        Flags: review?(kinetik)

        Attachment #8622867 -
        Flags: review?(kinetik) → review+

    
    

    
  
Thanks for the review.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/8204642eadbc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox41:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: