Move buffering check out of MediaDecoderStateMachine::UpdateRenderedVideoFrames()

RESOLVED FIXED in Firefox 43

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

(Blocks 1 bug)

unspecified
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 years ago
We should do it in the pop listeners and make AdvanceFrame() more coherent which should deal with video frame rendering and playback position updating only.
Assignee

Updated

4 years ago
Summary: Move buffering check out of MediaDecoderStateMachine::AdvanceFrame() → Move buffering check out of MediaDecoderStateMachine::UpdateRenderedVideoFrames()
Assignee

Comment 1

4 years ago
The bug would make it easier to extract the video rendering code to VideoSink.
Assignee

Updated

4 years ago
Assignee: nobody → jwwang
Blocks: 1199098
Assignee

Updated

4 years ago
Depends on: 1204401
Assignee

Comment 3

4 years ago
Bug 1172830 - Move buffering check out of MediaDecoderStateMachine::UpdateRenderedVideoFrames().
Attachment #8660563 - Flags: review?(cpearce)
Comment on attachment 8660563 [details]
MozReview Request: Bug 1172830 - Move buffering check out of MediaDecoderStateMachine::UpdateRenderedVideoFrames().

https://reviewboard.mozilla.org/r/19141/#review17119
Attachment #8660563 - Flags: review?(cpearce) → review+
Assignee

Comment 5

4 years ago
Thanks for the review.
https://hg.mozilla.org/mozilla-central/rev/9ad6f8144c5b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.