1172830 - Move buffering check out of MediaDecoderStateMachine::UpdateRenderedVideoFrames()

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

We should do it in the pop listeners and make AdvanceFrame() more coherent which should deal with video frame rendering and playback position updating only.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

The bug would make it easier to extract the video rendering code to VideoSink.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6885e074dd98

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1172830 - Move buffering check out of MediaDecoderStateMachine::UpdateRenderedVideoFrames().

Bug 1172830 - Move buffering check out of MediaDecoderStateMachine::UpdateRenderedVideoFrames().

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8660563 [details]
MozReview Request: Bug 1172830 - Move buffering check out of MediaDecoderStateMachine::UpdateRenderedVideoFrames().

https://reviewboard.mozilla.org/r/19141/#review17119

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ad6f8144c5b

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9ad6f8144c5b