1172861 - The /project/ endpoint should exclude repositories marked as onhold

Status: RESOLVED WORKSFORME

(Tree Management :: Treeherder: API, defect, P3)

Description

[Ed Morley [:emorley]]

Currently even if a repo is marked as onhold, we correctly hide it from the UI repo menu (since it is excluded from https://treeherder.mozilla.org/api/repository/).

However, we still allow requests for it's push/job data, eg:
https://treeherder.mozilla.org/api/project/mozilla-b2g30_v1_4/resultset/?count=10&full=true
https://treeherder.mozilla.org/api/project/mozilla-b2g30_v1_4/jobs/?count=2000&result_set_id=568&return_type=list

This means that it's not clear when visiting pages like:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-b2g30_v1_4
or
https://treeherder.mozilla.org/#/jobs?repo=mozilla-b2g30_v1_4&revision=27a812186ff4
...that the repo is disabled.

We should filter by active_status==active for the project endpoint (and anywhere else), not just the /repository/ endpoint. 

Speaking of which, why is it:
  /repository/ and /project/<name>/
rather than:
  /repository/ + /repository/<name/
or:
  /project/ + /project/<name/
?

Comment 1

[Ed Morley [:emorley]]

> Currently even if a repo is marked as onhold, we correctly hide it from the 

s/even//

Comment 2

[Balaji]

I would like to work on this bug. is this still open?

Comment 3

[Ed Morley [:emorley]]

This bug appears to have been fixed at some point in the last 3 years, since when I visit:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-b2g30_v1_4

...I get:

"""
Unknown repository.
This repository is either unknown to Treeherder or it doesn't exist. If this repository does exist, please file a bug against the Treeherder product in Bugzilla to get it added to the system. 
"""

Great - easy one to close out :-)