Closed
Bug 1172889
Opened 6 years ago
Closed 6 years ago
nsFrameLoader cleanup
Categories
(Core :: DOM: Content Processes, defect)
Core
DOM: Content Processes
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: kanru, Assigned: kanru)
References
Details
Attachments
(5 files)
|
40 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
roc
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
roc
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
While looking at nsFrameLoader for prototyping process isolation, I found nsFrameLoader need some cleanup.
|
Assignee | |
Comment 1•6 years ago
|
||
Bug 1172889 - Remove unused nsFrameLoader::DestroyChild. r?smaug
Attachment #8617278 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Bug 1172889 - Remove unused nsFrameLoader::mContentParent. r?smaug
Attachment #8617279 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 3•6 years ago
|
||
Bug 1172889 - Get current RenderFrameParent from TabParent directly. r?roc
Attachment #8617280 -
Flags: review?(roc)
|
|
Assignee | |
Comment 4•6 years ago
|
||
Bug 1172889 - Rename nsFrameLoader::GetCurrentRemoteFrame to nsFrameLoader::GetCurrentRenderFrame. r?roc
Attachment #8617281 -
Flags: review?(roc)
|
|
Assignee | |
Comment 5•6 years ago
|
||
Bug 1172889 - Reorder nsFrameLoader member declarations. r?smaug
Attachment #8617282 -
Flags: review?(bugs)
|
||
Updated•6 years ago
|
Attachment #8617278 -
Flags: review?(bugs) → review+
|
|
||
Comment 6•6 years ago
|
||
Comment on attachment 8617279 [details] MozReview Request: Bug 1172889 - Remove unused nsFrameLoader::mContentParent. r?smaug Ok, ContantParent stays alive via TabParent::mManager. But please test killing child process and ensure that the the normal tab restoration works in e10s.
Attachment #8617279 -
Flags: review?(bugs) → review+
|
|
||
Updated•6 years ago
|
Attachment #8617282 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 7•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6ede7f32203
Comment on attachment 8617280 [details] MozReview Request: Bug 1172889 - Get current RenderFrameParent from TabParent directly. r?roc https://reviewboard.mozilla.org/r/10595/#review9367 Ship It!
Attachment #8617280 -
Flags: review?(roc) → review+
Attachment #8617281 -
Flags: review?(roc) → review+
Comment on attachment 8617281 [details] MozReview Request: Bug 1172889 - Rename nsFrameLoader::GetCurrentRemoteFrame to nsFrameLoader::GetCurrentRenderFrame. r?roc https://reviewboard.mozilla.org/r/10597/#review9369 Ship It!
|
||
Comment 10•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/86611ea11908 https://hg.mozilla.org/integration/mozilla-inbound/rev/37ced3e92a8e https://hg.mozilla.org/integration/mozilla-inbound/rev/714ae742fdca https://hg.mozilla.org/integration/mozilla-inbound/rev/8da9514a858c https://hg.mozilla.org/integration/mozilla-inbound/rev/d17480aae980
https://hg.mozilla.org/mozilla-central/rev/86611ea11908 https://hg.mozilla.org/mozilla-central/rev/37ced3e92a8e https://hg.mozilla.org/mozilla-central/rev/714ae742fdca https://hg.mozilla.org/mozilla-central/rev/8da9514a858c https://hg.mozilla.org/mozilla-central/rev/d17480aae980
Assignee: nobody → kanru
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•