Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kanru, Assigned: kanru)

Tracking

unspecified
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(5 attachments)

Assignee

Description

4 years ago
While looking at nsFrameLoader for prototyping process isolation, I found nsFrameLoader need some cleanup.
Assignee

Comment 1

4 years ago
Bug 1172889 - Remove unused nsFrameLoader::DestroyChild. r?smaug
Attachment #8617278 - Flags: review?(bugs)
Assignee

Comment 2

4 years ago
Bug 1172889 - Remove unused nsFrameLoader::mContentParent. r?smaug
Attachment #8617279 - Flags: review?(bugs)
Assignee

Comment 3

4 years ago
Bug 1172889 - Get current RenderFrameParent from TabParent directly. r?roc
Attachment #8617280 - Flags: review?(roc)
Assignee

Comment 4

4 years ago
Bug 1172889 - Rename nsFrameLoader::GetCurrentRemoteFrame to nsFrameLoader::GetCurrentRenderFrame. r?roc
Attachment #8617281 - Flags: review?(roc)
Assignee

Comment 5

4 years ago
Bug 1172889 - Reorder nsFrameLoader member declarations. r?smaug
Attachment #8617282 - Flags: review?(bugs)
Attachment #8617278 - Flags: review?(bugs) → review+
Comment on attachment 8617279 [details]
MozReview Request: Bug 1172889 - Remove unused nsFrameLoader::mContentParent. r?smaug

Ok, ContantParent stays alive via TabParent::mManager.
But please test killing child process and ensure that the 
the normal tab restoration works in e10s.
Attachment #8617279 - Flags: review?(bugs) → review+
Attachment #8617282 - Flags: review?(bugs) → review+
Comment on attachment 8617280 [details]
MozReview Request: Bug 1172889 - Get current RenderFrameParent from TabParent directly. r?roc

https://reviewboard.mozilla.org/r/10595/#review9367

Ship It!
Attachment #8617280 - Flags: review?(roc) → review+
Comment on attachment 8617281 [details]
MozReview Request: Bug 1172889 - Rename nsFrameLoader::GetCurrentRemoteFrame to nsFrameLoader::GetCurrentRenderFrame. r?roc

https://reviewboard.mozilla.org/r/10597/#review9369

Ship It!
You need to log in before you can comment on or make changes to this bug.