Closed Bug 1172925 Opened 5 years ago Closed 5 years ago

Remove 'if test "$OS_TARGET" != "WINNT"; then...fi' in b2g/confvars.sh referred to by Bug 1171082

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
2.2 S14 (12june)
Tracking Status
firefox41 --- fixed

People

(Reporter: kdavis, Assigned: kdavis)

References

Details

(Whiteboard: [webspeechapi][systemsfe])

Attachments

(1 file)

Bug 1171082 referred to code of the form

# Bug 1171082 - Broken on Windows B2G Desktop
if test "$OS_TARGET" != "WINNT"; then
# Other build code
fi

in b2g/confvars.sh used to protect windows B2G builds
as a result of a problem in Bug 1051146.

When Bug 1171082 was resolved Bug 1171082 indicated that
this code that protected windows B2G builds needed to be
removed.

So, the task of this bug is to remove this code leaving

# Other build code
Depends on: 1171082
Assignee: nobody → kdavis
Whiteboard: [webspeechapi][systemsfe]
Target Milestone: --- → 2.2 S14 (12june)
Blocks: 1051148
Part 1 of 1:  Patch re-enables pocketsphinx, sphinxbase, and models on Windows B2G builds

This patch is part 1 of 1 for this bug.

This patch removes the if/fi code from Bug 1171082 that prevented Pocketsphinx
and Sphinxbase from being built in a Windows B2G build. So, for the try the
only really important thing is that the B2G Windows builds work.

The try for this patch is running here https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bacd5a9f082
Attachment #8617743 - Flags: review?(gps)
Comment on attachment 8617743 [details] [diff] [review]
Part 1 of 1:  Patch re-enables pocketsphinx, sphinxbase, and models on Windows B2G builds

Review of attachment 8617743 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.
Attachment #8617743 - Flags: review?(gps) → review+
Keywords: checkin-needed
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.