1172987 - Incorrect padding for various locales

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Comment 1

[Marina Samuel [:emtwo]]

Attachment: padding-fixes

Addressed issues in bug 1164594 comment 13

Comment 2

[Ed Lee :Mardak]

Comment on attachment 8617402 [details] [diff] [review]
padding-fixes

>+++ b/browser/base/content/newtab/intro.js
>+          image = document.createElementNS(HTML_NAMESPACE, "div");
>           image.classList.add("newtab-intro-image-customize");
>+          let imageToCopy = document.getElementById("newtab-customize-panel").cloneNode(true);
>+          while (imageToCopy.firstChild) {
>+            image.appendChild(imageToCopy.firstChild);
>+          }
>+          image.setAttribute("id", "newtab-customize-panel");
Probably should add a comment for why we need to copy things over. Any good way for us to avoid having multiple nodes with the same id?

>+++ b/browser/base/content/newtab/newTab.css
>   transition: opacity .5s linear;
>   overflow: auto;
>   display: none;
>+
>+  text-align: center;
nit: extra space

>+#newtab-intro-text {
>+  text-align: left;
>+  right: 0px;
>+  max-width: 270px;
>+}
>+
> #newtab-intro-text,
> #newtab-intro-image {
>   height: 100%;
>-  width: 270px;
>   right: 0px;
>-  position: absolute;
>   font-size: 14px;
>   line-height: 20px;
>   margin-top: -12px;
>+  min-width: 290px;
Not sure if this will cause problems with max-width set to 270 then min-width 290. I seem to be running into issues if I resize the window smaller with the intro-text pushed down into the buttons.

Comment 3

[Marina Samuel [:emtwo]]

Attachment: v2: Padding fixes

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e7c0ddb5f948

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e7c0ddb5f948

Comment 7

[Ed Lee :Mardak]

Verified attachment 8621682 [details] bug 1165394 comment 9

Comment 8

[Marina Samuel [:emtwo]]

Attachment: [aurora] Padding fixes

Approval Request Comment

[Feature/regressing bug #]: 1138818 and 1158859 

[User impact if declined]: Padding issues in various locales. Screenshots in bug 1164594

[Describe test coverage new/current, TreeHerder]: verified on nightly. tested locally on aurora

[Risks and why]: low risk - mostly CSS changes

[String/UUID change made/needed]: N/A

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8622712 [details] [diff] [review]
[aurora] Padding fixes

Polish this new feature, taking it.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Looks like Marina landed this. Please don't forget to mark the bug accordingly in the future.
https://hg.mozilla.org/releases/mozilla-aurora/rev/9f5f01ca0c12