Closed Bug 1173005 Opened 5 years ago Closed 5 years ago

Tweak the button and checkbox options alignment in the pseudolock class options panel

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: gl, Assigned: gl)

Details

Attachments

(2 files)

I made the following suggestions to shorlander:

(1) Use a button that is highlighted blue similar to the element picker when selected instead of the current blue background.

(2) Left align the options but make each item take equal spacing https://cloudup.com/cefTEeH79Dq
Assignee: nobody → gabriel.luong
(In reply to Gabriel Luong [:gl] from comment #0)
> I made the following suggestions to shorlander:
> 
> (1) Use a button that is highlighted blue similar to the element picker when
> selected instead of the current blue background.
There's an unwanted CSS filter applied there unfortunately, which makes the icon brown when checked.

Bug 1173397 should fix this.
Attached patch 1173005.patchSplinter Review
Attachment #8622044 - Flags: review?(bgrinstead)
- Fixed a margin issue appearing beneath the panel when inspecting pseudoelements. See https://cloudup.com/cBBSnEbJzhH
- Made the labels grow to take up the empty space
Status: NEW → ASSIGNED
Attachment #8622044 - Flags: review?(bgrinstead) → review+
Attachment #8622044 - Flags: ui-review?(shorlander)
@shorlander, just need a quick ui-review for the left alignments of the checkbox options. See https://cloudup.com/cgX0MZyZ_F1
Attachment #8622044 - Flags: ui-review?(shorlander)
No try needed since it is only css changes.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e3cc6999546b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.