Closed Bug 1173098 Opened 9 years ago Closed 9 years ago

[Contacts][NGA] Remove dependency with Contacts.confirmDialog.

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
NGA S2 (12Jun)
Tracking Flags:
Tracking Status
b2g-master --- fixed

People

(Reporter: borjasalguero, Assigned: jorgep)

References

Details

(Whiteboard: [NG Gaia Contacts])

Attachments

(1 file)

30547.html
384 bytes, text/html
borjasalguero
: review+
arcturus
: review+
borjasalguero
: feedback+
Details 
ConfirmDialog should not be loaded from Contacts. It's an entity that should be loaded directly, without going through Contacts.
Blocks: 1169191
Whiteboard: [NG Gaia Contacts]
Target Milestone: --- → NGA S2 (12Jun)
Assignee: nobody → jpruden92
Status: NEW → ASSIGNED
Attached file 30547.html — 

        Attachment #8621052 -
        Flags: feedback?(borja.bugzilla)

    
    

    
  
Comment on attachment 8621052 [details]
30547.html

Small comment to address and this is ready to review!

        Attachment #8621052 -
        Flags: feedback?(borja.bugzilla) → feedback+

    
  

        Attachment #8621052 -
        Flags: review?(francisco)

        Attachment #8621052 -
        Flags: review?(borja.bugzilla)

    
    

    
  
Comment on attachment 8621052 [details]
30547.html

Great job!

        Attachment #8621052 -
        Flags: review?(borja.bugzilla) → review+

    
    

    
  
Comment on attachment 8621052 [details]
30547.html

LGTM, tested on the phone.

Just left a comment in gh, regarding the unit tests.

Thanks!

        Attachment #8621052 -
        Flags: review?(francisco) → review+

    
    

    
  
All changes done!

Thanks :-)

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #4)
> Comment on attachment 8621052 [details]
> 30547.html
> 
> LGTM, tested on the phone.
> 
> Just left a comment in gh, regarding the unit tests.
> 
> Thanks!
Flags: needinfo?(francisco)

    
  
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Flags: needinfo?(francisco)

    
    

    
      
  
blocking-b2g: 2.2? → ---

          tracking-b2g:
          backlog → ---
ux-b2g: - → ---

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: