[Contacts][NGA] Remove dependency with Contacts.confirmDialog.

RESOLVED FIXED in Firefox OS master

Status

Firefox OS
Gaia::Contacts
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: borjasalguero, Assigned: jorgep)

Tracking

(Blocks: 1 bug)

unspecified
NGA S2 (12Jun)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-master fixed)

Details

(Whiteboard: [NG Gaia Contacts])

Attachments

(1 attachment)

384 bytes, text/html
borjasalguero
: review+
arcturus
: review+
borjasalguero
: feedback+
Details
(Reporter)

Description

3 years ago
ConfirmDialog should not be loaded from Contacts. It's an entity that should be loaded directly, without going through Contacts.
(Reporter)

Updated

3 years ago
Blocks: 1169191
Whiteboard: [NG Gaia Contacts]
Target Milestone: --- → NGA S2 (12Jun)
(Assignee)

Updated

3 years ago
Assignee: nobody → jpruden92
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8621052 [details]
30547.html
Attachment #8621052 - Flags: feedback?(borja.bugzilla)
(Reporter)

Comment 2

3 years ago
Comment on attachment 8621052 [details]
30547.html

Small comment to address and this is ready to review!
Attachment #8621052 - Flags: feedback?(borja.bugzilla) → feedback+
(Assignee)

Updated

3 years ago
Attachment #8621052 - Flags: review?(francisco)
Attachment #8621052 - Flags: review?(borja.bugzilla)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8621052 [details]
30547.html

Great job!
Attachment #8621052 - Flags: review?(borja.bugzilla) → review+
Comment on attachment 8621052 [details]
30547.html

LGTM, tested on the phone.

Just left a comment in gh, regarding the unit tests.

Thanks!
Attachment #8621052 - Flags: review?(francisco) → review+
(Assignee)

Comment 5

3 years ago
All changes done!

Thanks :-)

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #4)
> Comment on attachment 8621052 [details]
> 30547.html
> 
> LGTM, tested on the phone.
> 
> Just left a comment in gh, regarding the unit tests.
> 
> Thanks!
Flags: needinfo?(francisco)
(Reporter)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Flags: needinfo?(francisco)
status-b2g-master: --- → fixed
Comment hidden (spam)
blocking-b2g: 2.2? → ---
tracking-b2g: backlog → ---
ux-b2g: - → ---
You need to log in before you can comment on or make changes to this bug.