1173125 - Submitting new unlisted add-on/uploading new version of any add-on fails when supporting multiple platforms

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Kris Maglione [:kmag]]

When creating a new version, or submitting a new add-on, with explicit support for multiple platforms (rather than support for 'All Platforms'), multiple File objects are created. The code for automated signing assumes there will only ever be one, so fails in these cases with `MultipleObjectsReturned: get() returned more than one File`:

http://sentry.mktmon.services.phx1.mozilla.com/mkt/addonsmozillaorg/group/15918/
http://sentry.mktmon.services.phx1.mozilla.com/mkt/addonsmozillaorg/group/15955/

Comment 1

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/579

STR: submit a new unlisted addon, and instead of selecting "All platforms", select (at least) two platforms. It should work correctly, and not display the "oops" page.

Comment 2

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/ebf27349b53dd20da694b051dfe8ff969a2330ad

Comment 3

[Madalin Cotetiu]

Verified as fixed in FF38(Win7) in addons-dev.allizom.org
Postfix screencast: http://screencast.com/t/YcP3KSiDR
Closing bug.