1173139 - Don't create the worker global until we know the final principal

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Creating the global before we know the final principal could let us define inappropriate bindings if we ever decide to let system-principal callers create non-system-principal workers. This patch moves the global creation later.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8617601 [details] [diff] [review]
Patch, v1

Review of attachment 8617601 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/WorkerPrivate.h
@@ +696,5 @@
>    void
>    CopyJSCompartmentOptions(JS::CompartmentOptions& aOptions)
>    {
>      mozilla::MutexAutoLock lock(mMutex);
> +    aOptions = UsesSystemPrincipal() ? mJSSettings.chrome.compartmentOptions

After thinking about this more I'm convinced the current code is better, so I'm not going to land this part.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/49480f1c4071

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/49480f1c4071