"Cast your vote" action items should consider "voted" status

VERIFIED FIXED

Status

Mozilla Reps
reps.mozilla.org
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: mkohler, Assigned: tasos)

Tracking

Details

(Whiteboard: [kb=1772163] [qa-])

(Reporter)

Description

3 years ago
Currently I have an action item regarding "Cast your vote" for a Budget Request even though I have already voted on it. Since the Portal can also detect that I have already voted, it probably could also remove those action items from my dashboard.

Example: https://reps.mozilla.org/v/budget-request-jefferson-duran-https-reps-mozilla-org-e-encuentro-de-activistas-digitales-de-lenguas-indigenas-bogota/
(Assignee)

Updated

3 years ago
Assignee: nobody → tasos
Group: mozilla-reps-admins
Status: NEW → ASSIGNED
Whiteboard: [kb=1772163]
(Assignee)

Comment 1

3 years ago
A celery task is assigned to run every 4 hours in order to create action items for every available poll, if there aren't any. The problem here is that we didn't check if a user had already voted in the meantime. @mkohler: Nice catch!

A new pr opened here:
https://github.com/mozilla/remo/pull/1047

Comment 2

3 years ago
Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/f44a27eec1ebc390f88d0eedca5157c4d21ea2a3
[fix bug 1173175] Do not assign action items to people who already voted.

https://github.com/mozilla/remo/commit/7b32aec303c6d193250eb574e08df011ce8f4459
Merge pull request #1047 from akatsoulas/1173175-voted-action-items

[fix bug 1173175] Do not assign action items to people who already vo…

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Version: unspecified → next
Status: RESOLVED → VERIFIED
Whiteboard: [kb=1772163] → [kb=1772163] [qa-]
(Assignee)

Updated

3 years ago
Version: next → 470
You need to log in before you can comment on or make changes to this bug.