Closed
Bug 1173182
Opened 9 years ago
Closed 9 years ago
Fennec ARM telemetry environment contains x86-specific flags
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(1 file)
1006 bytes,
patch
|
gfritzsche
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
I recently dumped about:telemetry on the Galaxy S4 test device that I'm running for content performance work. I noticed this: cpu.extensions [hasMMX, hasSSE, hasSSE2, hasSSE3, hasSSSE3, hasSSE4A, hasSSE4_1, hasSSE4_2, hasEDSP, hasARMv6, hasARMv7, hasNEON] I don't think that ARM processors should have Intel's MMX and SSE extensions present! :-)
Assignee | ||
Comment 1•9 years ago
|
||
The cpu hasXXX flags have always been booleans. Checking for the key's presence is insufficient.
Comment 2•9 years ago
|
||
Comment on attachment 8617650 [details] [diff] [review] Fix Review of attachment 8617650 [details] [diff] [review]: ----------------------------------------------------------------- Ouch, good catch.
Attachment #8617650 -
Flags: review?(gfritzsche) → review+
Updated•9 years ago
|
OS: Unspecified → All
Hardware: ARM → All
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/01ae75cfedd0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8617650 [details] [diff] [review] Fix Approval Request Comment [Feature/regressing bug #]: Bug 1122052 [User impact if declined]: Telemetry pings will contain invalid data about CPU features [Describe test coverage new/current, TreeHerder]: On m-c [Risks and why]: None, trivial fix [String/UUID change made/needed]: None
Attachment #8617650 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox40:
--- → affected
Comment 6•9 years ago
|
||
Comment on attachment 8617650 [details] [diff] [review] Fix We want to have clean data, taking it.
Attachment #8617650 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b7fbb032f2a2
Updated•9 years ago
|
Whiteboard: [uplift]
You need to log in
before you can comment on or make changes to this bug.
Description
•