Closed Bug 1173182 Opened 4 years ago Closed 4 years ago

Fennec ARM telemetry environment contains x86-specific flags

Categories

(Toolkit :: Telemetry, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

Attachments

(1 file)

I recently dumped about:telemetry on the Galaxy S4 test device that I'm running for content performance work. I noticed this:

cpu.extensions [hasMMX, hasSSE, hasSSE2, hasSSE3, hasSSSE3, hasSSE4A, hasSSE4_1, hasSSE4_2, hasEDSP, hasARMv6, hasARMv7, hasNEON]

I don't think that ARM processors should have Intel's MMX and SSE extensions present! :-)
Attached patch FixSplinter Review
The cpu hasXXX flags have always been booleans. Checking for the key's presence is insufficient.
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Attachment #8617650 - Flags: review?(gfritzsche)
Comment on attachment 8617650 [details] [diff] [review]
Fix

Review of attachment 8617650 [details] [diff] [review]:
-----------------------------------------------------------------

Ouch, good catch.
Attachment #8617650 - Flags: review?(gfritzsche) → review+
Blocks: 1120356
Whiteboard: [uplift]
OS: Unspecified → All
Hardware: ARM → All
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/01ae75cfedd0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment on attachment 8617650 [details] [diff] [review]
Fix

Approval Request Comment
[Feature/regressing bug #]: Bug 1122052
[User impact if declined]: Telemetry pings will contain invalid data about CPU features
[Describe test coverage new/current, TreeHerder]: On m-c
[Risks and why]: None, trivial fix
[String/UUID change made/needed]: None
Attachment #8617650 - Flags: approval-mozilla-aurora?
Comment on attachment 8617650 [details] [diff] [review]
Fix

We want to have clean data, taking it.
Attachment #8617650 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [uplift]
You need to log in before you can comment on or make changes to this bug.