1173212 - PLDHashTable::Iterator is busted in chaos mode

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

I've started converting some PL_DHashTableEnumerate() calls to PLDHashTable::Iterator usages, because the iterator is much nicer. But a try push has revealed that the iterator is broken in chaos mode.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Replace some can't-fail tests in PLDHashTable with assertions

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Make PLDHashTable::Iterator work in chaos mode

This fixes the crashes I was getting on some mochitests with other patches that
used PLDHashTable::Iterator.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove some can't-fail tests in PLDHashTable

I changed my mind, because a couple of the local variables were debug-only for
the asserts. They're vacuous asserts, let's just get rid of them.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8617691 [details] [diff] [review]
(part 2) - Make PLDHashTable::Iterator work in chaos mode

Review of attachment 8617691 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e14d67e27eab
https://hg.mozilla.org/integration/mozilla-inbound/rev/830bf11bfe1d

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e14d67e27eab
https://hg.mozilla.org/mozilla-central/rev/830bf11bfe1d