Closed Bug 1173212 Opened 6 years ago Closed 6 years ago

PLDHashTable::Iterator is busted in chaos mode

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(2 files, 1 obsolete file)

I've started converting some PL_DHashTableEnumerate() calls to PLDHashTable::Iterator usages, because the iterator is much nicer. But a try push has revealed that the iterator is broken in chaos mode.
This fixes the crashes I was getting on some mochitests with other patches that
used PLDHashTable::Iterator.
Attachment #8617691 - Flags: review?(nfroyd)
I changed my mind, because a couple of the local variables were debug-only for
the asserts. They're vacuous asserts, let's just get rid of them.
Attachment #8617705 - Flags: review?(nfroyd)
Attachment #8617688 - Attachment is obsolete: true
Attachment #8617688 - Flags: review?(nfroyd)
Attachment #8617705 - Flags: review?(nfroyd) → review+
Comment on attachment 8617691 [details] [diff] [review]
(part 2) - Make PLDHashTable::Iterator work in chaos mode

Review of attachment 8617691 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.
Attachment #8617691 - Flags: review?(nfroyd) → review+
You need to log in before you can comment on or make changes to this bug.