Closed
Bug 1173256
Opened 7 years ago
Closed 7 years ago
Intermittent test_bug1012662_editor.html | Keydown caused cut invocation 0 - 1 - 5 - got true, expected false
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: cbook, Unassigned)
References
()
Details
(Keywords: intermittent-failure)
Attachments
(2 files, 1 obsolete file)
1.29 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
1.30 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
mozilla-inbound_ubuntu64_vm-b2g-emulator-debug_test-mochitest-debug-16 https://treeherder.mozilla.org/logviewer.html#?job_id=10581196&repo=mozilla-inbound 21:59:07 INFO - 52 INFO TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_bug1012662_editor.html | Keydown caused cut invocation 0 - 1 - 5 - got true, expected false
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 3•7 years ago
|
||
This patch adds a logging message for a potential cause of this intermittent failure.
Attachment #8620444 -
Flags: review?(ehsan)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 5•7 years ago
|
||
Comment on attachment 8620444 [details] [diff] [review] Debug log for potential cause of intermittent failure Review of attachment 8620444 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/events/EventStateManager.cpp @@ +3713,5 @@ > + > + if (!inTime) { > + printf("EventStateManager::IsHandlingUserInput() has timed out " > + "(timeout: %f, elapsed: %f)\n", > + timeout.ToMilliseconds(), elapsed.ToMilliseconds()); Please do the printf #ifdef DEBUG. We shouldn't print to stdout in non-debug builds like this.
Attachment #8620444 -
Flags: review?(ehsan) → review-
Comment 6•7 years ago
|
||
Added #ifdef DEBUG around logging statement
Attachment #8620444 -
Attachment is obsolete: true
Attachment #8621537 -
Flags: review?(ehsan)
Updated•7 years ago
|
Attachment #8621537 -
Flags: review?(ehsan) → review+
Updated•7 years ago
|
Keywords: checkin-needed,
leave-open
Comment 9•7 years ago
|
||
Do we still need the DEBUG code? That is causing quite some output to terminal in some cases.
Comment 10•7 years ago
|
||
I haven't seen any occurrences of this intermittent failure since the first two on the day this was filed. I'm fine with backing the debug changes out because we aren't seeing the failures.
Comment hidden (Legacy TBPL/Treeherder Robot) |
This is really spammy. Please remove it as soon as possible.
Flags: needinfo?(michael)
Comment 13•7 years ago
|
||
This patch will remove the debug log. It appears as though it is unrelated to the problem.
Attachment #8628835 -
Flags: review?(ehsan)
Updated•7 years ago
|
Flags: needinfo?(michael)
Comment 14•7 years ago
|
||
Comment 11 gives us what we want here, FWIW.
Comment 15•7 years ago
|
||
Comment on attachment 8628835 [details] [diff] [review] Remove debug log for potential cause of intermittent failure I'll back out the previous patch for you.
Attachment #8628835 -
Flags: review?(ehsan) → review+
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 20•7 years ago
|
||
[Mass Closure] Closing Intermittent as a one off
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Comment 21•4 years ago
|
||
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
Assignee | ||
Updated•3 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•