Intermittent test_bug1012662_editor.html | Keydown caused cut invocation 0 - 1 - 5 - got true, expected false




4 years ago
4 months ago


(Reporter: cbook, Unassigned)



Firefox Tracking Flags

(Not tracked)




(2 attachments, 1 obsolete attachment)


21:59:07 INFO - 52 INFO TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_bug1012662_editor.html | Keydown caused cut invocation 0 - 1 - 5 - got true, expected false
This patch adds a logging message for a potential cause of this intermittent failure.
Attachment #8620444 - Flags: review?(ehsan)
Comment on attachment 8620444 [details] [diff] [review]
Debug log for potential cause of intermittent failure

Review of attachment 8620444 [details] [diff] [review]:

::: dom/events/EventStateManager.cpp
@@ +3713,5 @@
> +
> +  if (!inTime) {
> +    printf("EventStateManager::IsHandlingUserInput() has timed out "
> +           "(timeout: %f, elapsed: %f)\n",
> +           timeout.ToMilliseconds(), elapsed.ToMilliseconds());

Please do the printf #ifdef DEBUG.  We shouldn't print to stdout in non-debug builds like this.
Attachment #8620444 - Flags: review?(ehsan) → review-
Added #ifdef DEBUG around logging statement
Attachment #8620444 - Attachment is obsolete: true
Attachment #8621537 - Flags: review?(ehsan)
Attachment #8621537 - Flags: review?(ehsan) → review+
Do we still need the DEBUG code? That is causing quite some output to terminal in some cases.
I haven't seen any occurrences of this intermittent failure since the first two on the day this was filed. I'm fine with backing the debug changes out because we aren't seeing the failures.
This is really spammy. Please remove it as soon as possible.
Flags: needinfo?(michael)
This patch will remove the debug log. It appears as though it is unrelated to the problem.
Attachment #8628835 - Flags: review?(ehsan)
Flags: needinfo?(michael)
Comment 11 gives us what we want here, FWIW.
Comment on attachment 8628835 [details] [diff] [review]
Remove debug log for potential cause of intermittent failure

I'll back out the previous patch for you.
Attachment #8628835 - Flags: review?(ehsan) → review+
[Mass Closure] Closing Intermittent as a one off
Closed: 4 years ago
Resolution: --- → WORKSFORME
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.