Closed Bug 1173274 Opened 10 years ago Closed 10 years ago

[Contacts][NGA] 'NFC' out of Contacts

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S2 (10Jul)

People

(Reporter: borjasalguero, Assigned: fcampo)

References

Details

(Whiteboard: [NG Gaia Contacts][patch])

Attachments

(1 file)

Pull Request - https://github.com/mozilla-b2g/gaia/pull/30669
46 bytes, text/x-github-pull-request
arcturus
: review+
borjasalguero
: feedback+
Details | Review
Currently we are 'stopping' NFC just to prevent errors when navigating back to the list. This should be handled by the list itself, not by every view (we are duplicating code and adding a not-needed dependency)
Blocks: 1169191
Whiteboard: [NG Gaia Contacts]
Target Milestone: --- → NGA S2 (12Jun)
Assignee: nobody → fernando.campo
Status: NEW → ASSIGNED
Target Milestone: NGA S2 (12Jun) → NGA S3 (26Jun)
As NGA Program Manager suggested, let's replace the NGA-X milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed
Target Milestone: NGA S3 (26Jun) → FxOS-S1 (26Jun)
morphing the bug title after discussion and tests. NFC sharing should only work when we are on Detail view, so no interaction from Form (edit mode) or List is necessary.
Summary: [Contacts][NGA] 'contacts.NFC.stopListening' must be moved out of 'form.js' and 'detail.js' → [Contacts][NGA] 'NFC' out of Contacts
Attachment #8624686 - Flags: review?(francisco)
Attachment #8624686 - Flags: review?(borja.bugzilla)
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]
Comment on attachment 8624686 [details] [review] Pull Request - https://github.com/mozilla-b2g/gaia/pull/30669 Some comments in Github. Let me know when ready and I'll take the final review of this! Thanks!
Attachment #8624686 - Flags: review?(borja.bugzilla) → feedback+
Comment on attachment 8624686 [details] [review] Pull Request - https://github.com/mozilla-b2g/gaia/pull/30669 Just did first pass, getting closer. Left some comments on gh.
Attachment #8624686 - Flags: review?(francisco)
Target Milestone: FxOS-S1 (26Jun) → FxOS-S2 (10Jul)
Comment on attachment 8624686 [details] [review] Pull Request - https://github.com/mozilla-b2g/gaia/pull/30669 updated PR, please re-review
Attachment #8624686 - Flags: review?(francisco)
Comment on attachment 8624686 [details] [review] Pull Request - https://github.com/mozilla-b2g/gaia/pull/30669 Thanks Fernando, left just one comment on gh, once addressed please merge :)
Attachment #8624686 - Flags: review?(francisco) → review+
updated and green again, thanks for the comments master - https://github.com/mozilla-b2g/gaia/commit/66ed1537ff73329cb197dd241eeec4aa6d627431
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: