1173313 - [SMS] Use 'copy-text' instead of 'select-text' when long-pressing sent messages in conversation history.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Jeremy Chen ([e-mail])]

In the original selet-text option, we need two steps to copy a sent message:
1. use selectAllChildren() to select text
2. press selection bubble to select the texts

Since Bug 1012662 provide new api about copy/paste. We should be able to use this feature to provide a single step solution to copy a sent message.

Comment 1

[Jeremy Chen ([e-mail])]

Attachment: PR

Hi Steve, please take a look at this. Thx :)

Comment 2

[Julien Wajsberg [:julienw]]

Jeremy, how do we copy only a part of a message with this change ?

Comment 3

[Jeremy Chen ([e-mail])]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> Jeremy, how do we copy only a part of a message with this change ?

Once we tap 'copy-text', focus has been changed to the message, so we can long press to select partial text of the message. But, it seems not trivial for users....hmmm. 

How about keeping the original 'select-text' function as before and add 'copy-message' as a new option? In that case, users can easily select part of a message from 'select-text', and they are also able to use 'copy-message' as a shortcut to copy a whole message.

Comment 4

[Julien Wajsberg [:julienw]]

This is a question to Jenny :)

Comment 5

[Steve Chung [:steveck]]

(In reply to Jeremy Chen [:jeremychen] from comment #3)
> (In reply to Julien Wajsberg [:julienw] from comment #2)
> > Jeremy, how do we copy only a part of a message with this change ?
> 
> Once we tap 'copy-text', focus has been changed to the message, so we can
> long press to select partial text of the message. But, it seems not trivial
> for users....hmmm. 
> 
> How about keeping the original 'select-text' function as before and add
> 'copy-message' as a new option? In that case, users can easily select part
> of a message from 'select-text', and they are also able to use
> 'copy-message' as a shortcut to copy a whole message.

Yep I think it's a good question for UX. To me that removing the selectable text range seems a little bit inconvenience, but having both option might be a considerable choice.

Comment 6

[Jenny Lee]

Hi Jeremy,
 
Context menu as it is already pretty full, also, user can easily copy all the text with current design (just one more tap). If we add one more option (copy text), user would have to distinguish and determine which option is desired at menu level (What's the difference between "select text" and "copy text"? which one do I want?), which would potentially require more mental effort. So I wouldn't suggest adding "copy text". Thanks!

Comment 7

[Julien Wajsberg [:julienw]]

Let's close this bug then. Sorry Jeremy !

Comment 8

[Jeremy Chen ([e-mail])]

Comment on attachment 8617861 [details] [review]
PR

Clear the review request.

Comment 9

[Jeremy Chen ([e-mail])]

(In reply to Julien Wajsberg [:julienw] from comment #7)
> Let's close this bug then. Sorry Jeremy !

It's ok. Thank you all for the quick feedbacks.