Closed
Bug 1173330
Opened 9 years ago
Closed 9 years ago
Fix and re-enable browser_bug638292.js in e10s mode
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla44
People
(Reporter: RyanVM, Assigned: enndeakin)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
|
606.41 KB,
image/png
|
Details | |
|
4.38 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
test screenshot
This test was disabled and annotated at one point with a pointer to bug 1083269. That bug is fixed now, but a Try push from yesterday says it's still failing. https://treeherder.mozilla.org/logviewer.html#?job_id=8357482&repo=try
|
||
Updated•9 years ago
|
Blocks: e10s-tests
|
Assignee | |
Comment 1•9 years ago
|
||
That test needs a number of changes: - can just use BrowserTestUtils.openNewForegroundTab and not use waitForFocus - not do comparisons on the content document, and instead use a ContentTask. - use BrowserTestUtils.synthesizeMouseAtCenter instead.
|
|
Assignee | |
Comment 2•9 years ago
|
||
Haven't tested on e10s though.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8621043 -
Attachment is obsolete: true
Attachment #8670216 -
Flags: review?(felipc)
|
||
Updated•9 years ago
|
Attachment #8670216 -
Flags: review?(felipc) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/509dfb8dffa103a637e474fab8db61b9ea651072 Bug 1173330, fix to use content tasks and BrowserTestUtils, and reenable browser_bug638292.js, r=felipe
https://hg.mozilla.org/mozilla-central/rev/509dfb8dffa1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•