1173379 - More aggressive delay-initialization

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Bug 1166452 added a DelayedInit.jsm module that we can use to delay-load even moar things.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Delay-init more things on startup (v1)

Add more things to be delay-loaded. In particular, we can delay initializing the context menu items until NativeWindow.contextmenu is accessed.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Delay loading console and AndroidLog.jsm on startup (v1)

We can lazy-load AndroidLog.jsm until dump() is used, and by switching some console.log() calls to dump() calls, we can delay loading the console service.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Lazy-init console in browser-content.js (v1)

Since the console object is not used right away, we can load it lazily.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8621268 [details] [diff] [review]
Delay-init more things on startup (v1)

General comment: I'm not a big fan of pulling a bunch of initialization code out of the contextual location and putting it all in a single place.

One example of this is pulling CharacterEncoding.sendState out of the CharacterEncoding object. Why not keep CharacterEncoding.sendState in the CharacterEncoding.init() method, and move the CharacterEncoding.init method into the InitLater section?

The "click" event listeners also seem to want a better method of invocation. Maybe we could create a BrowserDeck helper like we do for nsIObserver notifications and message manager messages? That might be more work than you want to do for now, so how about just getting the CharacterEncoding object cleaned up a little?

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Delay-init more things on startup (v2)

(In reply to Mark Finkle (:mfinkle) from comment #4)
> Comment on attachment 8621268 [details] [diff] [review]
> Delay-init more things on startup (v1)
> 
> General comment: I'm not a big fan of pulling a bunch of initialization code
> out of the contextual location and putting it all in a single place.

Yeah that makes sense.

> One example of this is pulling CharacterEncoding.sendState out of the
> CharacterEncoding object. Why not keep CharacterEncoding.sendState in the
> CharacterEncoding.init() method, and move the CharacterEncoding.init method
> into the InitLater section?

I kept the original CharacterEncoding.init call because it registers observers, and (I think) we want that to happen before the Gecko:Ready event. In the new patch, I moved the InitLater(CharacterEncoding.sendState) call to inside CharacterEncoding.init. I also moved the click events back to their original location, with InitLater wrapped around them.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8622698 [details] [diff] [review]
Delay-init more things on startup (v2)

Thanks

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9905e191083a
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf6ee89903ae
https://hg.mozilla.org/integration/mozilla-inbound/rev/5adf4fc6a628

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9905e191083a
https://hg.mozilla.org/mozilla-central/rev/cf6ee89903ae
https://hg.mozilla.org/mozilla-central/rev/5adf4fc6a628