1173420 - default settings for experiments logging should be silent

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Nathan Froyd [:froydnj]]

prefs_general.js has this:

// AddonManager tests require that the experiments provider be present.
user_pref("experiments.supported", true);
user_pref("experiments.logging.level", "Trace");
user_pref("experiments.logging.dump", true);

which results in messages that are completely unnecessary when starting the browser:

1433955374188	Browser.Experiments.Experiments	TRACE	Experiments #0::enabled=true, true
1433955374189	Browser.Experiments.Experiments	TRACE	Experiments #0::Registering instance with Addon Manager.
1433955374189	Browser.Experiments.Experiments	TRACE	Experiments #0::Registering previous experiment add-on provider.
1433955374190	Browser.Experiments.Experiments	TRACE	PreviousExperimentProvider #0::startup()
1433955374190	Browser.Experiments.Experiments	TRACE	Experiments #0::_loadFromCache

It's not obvious to me whether the logging settings are necessary for the comment.  Can we turn off the logging globally and then (if needed) turn it on for the appropriate tests?  If not, can we make that supported, so we stop spamming useless trace messages?

Comment 1

[Eric Rahm [:erahm]]

This behavior was added in bug 995027 in order to help debug an intermittent. You can follow the progression there, essentially: land logging patch (leave-open), land more verbose logging patch (leave-open), eventually land fix.

995027 is now fixed, so we should turn off the logging again.

Comment 2

[Eric Rahm [:erahm]]

Attachment: Turn of experiments logging during testing

Setting 'experiments.logging.level' to trace seems to have been leftover
debugging code from bug 989137. Similarly enabling 'experiments.logging.dump'
was leftover from debugging bug 995027.

Comment 3

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9eeca233d15

Comment 4

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a767096d472

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4a767096d472