Closed
Bug 1173513
Opened 9 years ago
Closed 9 years ago
Point to SavedFrame.md docs from JSAPI comments
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file, 1 obsolete file)
1.63 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8620523 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
The pointer should be from the jsapi bits for async stacks/causes (also?), no?
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Not doing reviews right now from comment #2) > The pointer should be from the jsapi bits for async stacks/causes (also?), > no? Do you want to repeat the "See also ..." for each method? I personally think that's a bit much, but you are an API customer and I am not, so I defer to you.
Comment 4•9 years ago
|
||
Well. So I was reading the docs for AutoSetAsyncStackForNewCalls when I couldn't make sense of asyncCause. That's about 1000 lines above the line you're adding. What are my chances of starting at AutoSetAsyncStackForNewCalls and discovering that I should read SavedFrame.md for documentation on asyncCause?
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8620523 -
Attachment is obsolete: true
Attachment #8620662 -
Flags: review+
https://hg.mozilla.org/mozilla-central/rev/680292fc9f89
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•