Closed Bug 1173520 Opened 6 years ago Closed 6 years ago

Implement support for failed test screenshots on GTK3

Categories

(Core :: Widget: Gtk, defect)

Unspecified
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: acomminos, Assigned: acomminos)

References

Details

Attachments

(2 files, 2 obsolete files)

Currently, testing/tools/screenshot/gdk-screenshot.cpp is not implemented to take screenshots on GTK3.

It would be pretty nice to have screenshots of failed tests.
Summary: Implement support for screenshots on GTK3 → Implement support for failed test screenshots on GTK3
Attachment #8620532 - Flags: review?(karlt) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/63fd849c06a3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Unfortunately this doesn't build of Fedora 22.
Attached patch Proposed patch (obsolete) — Splinter Review
Karl

Since you reviewed the first one. This is a bustage for me.
Attachment #8621415 - Flags: review?(karlt)
Comment on attachment 8621415 [details] [diff] [review]
Proposed patch

>+#if (MOZ_WIDGET_GTK == 2)
>+      GDK_DISPLAY(),
>+#else
>+      GDK_DISPLAY_XDISPLAY(gdk_display_get_default()),
>+#endif

Thanks.  Please drop the (MOZ_WIDGET_GTK == 2) blocks as GDK_DISPLAY_XDISPLAY(gdk_display_get_default()) will work on GTK2 also.
Attachment #8621415 - Flags: review?(karlt) → review+
Attached patch Updated patch (obsolete) — Splinter Review
Carrying the r+
Attachment #8621415 - Attachment is obsolete: true
Attachment #8621424 - Flags: review+
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: FIXED → ---
Please attach a patch that includes all proper commit information.
Flags: needinfo?(hub)
Keywords: checkin-needed
Attached patch Updated patch.Splinter Review
Was missing "User". Carrying the r+ forward.
Attachment #8621424 - Attachment is obsolete: true
Flags: needinfo?(hub)
Attachment #8621609 - Flags: review+
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.