Closed Bug 1173520 Opened 6 years ago Closed 6 years ago
Implement support for failed test screenshots on GTK3
Currently, testing/tools/screenshot/gdk-screenshot.cpp is not implemented to take screenshots on GTK3. It would be pretty nice to have screenshots of failed tests.
Summary: Implement support for screenshots on GTK3 → Implement support for failed test screenshots on GTK3
Unfortunately this doesn't build of Fedora 22.
Karl Since you reviewed the first one. This is a bustage for me.
Attachment #8621415 - Flags: review?(karlt)
Comment on attachment 8621415 [details] [diff] [review] Proposed patch >+#if (MOZ_WIDGET_GTK == 2) >+ GDK_DISPLAY(), >+#else >+ GDK_DISPLAY_XDISPLAY(gdk_display_get_default()), >+#endif Thanks. Please drop the (MOZ_WIDGET_GTK == 2) blocks as GDK_DISPLAY_XDISPLAY(gdk_display_get_default()) will work on GTK2 also.
Attachment #8621415 - Flags: review?(karlt) → review+
Carrying the r+
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Please attach a patch that includes all proper commit information.
Was missing "User". Carrying the r+ forward.
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.