Closed Bug 1173526 Opened 10 years ago Closed 6 years ago

switch from model makers to factoryboy

Categories

(support.mozilla.org :: Code Quality, task)

Product:
support.mozilla.org
Component:
Code Quality
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: willkg, Unassigned)

Details

Currently, SUMO uses model makers that we threw together in a drunken stupor after having a deep conversation about how the world would be a better place if everyone could have free pizza. That idea, like everything else that night, was terrible. This bug covers nixing those model makers for factoryboy Factories which are way more flexible, powerful and will result in tests that are easier to reason about and maintain. https://factoryboy.readthedocs.org/en/latest/
Adding factoryboy and a few factories in a PR: https://github.com/mozilla/kitsune/pull/2569
Pushed to prod by me, right now.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
We only did a couple of model makers and I'm pretty sure most of the tests don't use them, yet. I'm going to reopen this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Closed as per https://blog.mozilla.org/sumo/2019/06/07/sumo-platform-roadmap/

Status: REOPENED → RESOLVED
Closed: 10 years ago → 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.