1173528 - Timeout while "waiting for containers to bootstrap" when setting up MozReview test environment

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Botond Ballo [:botond]]

While setting up a local MozReview test environment (by running './create-test-environment' in the version-control-tools repo), I ran into a timeout while "waiting for containers to bootstrap".

:gps and :mcote helped me investigate the cause of this (much thanks!)

Looking at what the container was doing via "docker logs -f <id>" revealed that it was just taking longer to bootstrap than the specified timeout value.

The timeout value is specified as the default argument to the wait_for_http() function in testing/vcttesting/util.py, and it's set to 60 seconds. 

Bumping that to 240 seconds allows me to bootstrap the container successfully (I first tried 120 seconds but that still wasn't enough.)

Comment 1

[Botond Ballo [:botond]]

Attachment: MozReview Request: testing: avoid timing out while waiting for containers to bootstrap (bug 1173528); r=mcote

testing: avoid timing out while waiting for containers to bootstrap (bug 1173528); r=mcote

Comment 2

[Mark Côté [:mcote]]

Comment on attachment 8620556 [details]
MozReview Request: testing: avoid timing out while waiting for containers to bootstrap (bug 1173528); r=mcote

https://reviewboard.mozilla.org/r/10791/#review9511

This is good, since some systems just take longer to bootstrap.  It will, however, cause us to have to wait longer for results when there are real failures in setting up the test environment, so I filed bug 1173880 to detect those earlier.

Comment 3

[Botond Ballo [:botond]]

I landed this patch on Monday, just forgot to post here (still getting used to the v-c-t workflow).

https://hg.mozilla.org/hgcustom/version-control-tools/rev/73cdd012d8ef