Closed Bug 1173540 Opened 9 years ago Closed 9 years ago

[fxos-automation] gaia/package.json shouldn't depend on jsmarionette dependencies + runner fails to catch failure

Categories

(Testing Graveyard :: JSMarionette, defect)

Product:
Testing Graveyard
Component:
JSMarionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: aus, Assigned: gaye)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

Pull Request - Add sanity check to gaia_marionette_retry.js
46 bytes, text/x-github-pull-request
gaye
: review+
Details | Review 
The runner is failing to catch the fact that we were supposed to run the tests present in env var TEST_FILES but didn't run any.

See https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=45937609c3de77d8a09db05f120941fdaa79aa46 for a build that exhibits this bug.
Summary: [fxos-automation] Test runner fails to catch failure → [fxos-automation] gaia/package.json shouldn't depend on jsmarionette dependencies + runner fails to catch failure
We'll roll out the fix for the ci bits that failed to catch the issue and the original patch.
Attachment #8620594 - Attachment is obsolete: true
Comment on attachment 8621316 [details] [review]
Pull Request - Add sanity check to gaia_marionette_retry.js

Nice one and thanks for investigating!
Attachment #8621316 - Flags: review?(gaye) → review+
CI bits commit (master): https://github.com/mozilla-b2g/gaia/commit/ea3596e28f503e7c606effc0848f48b1151a819e

Ready to land your stuff :gaye :)
Assigning to :gaye since he will land the rest of the code associated with this bug.
Assignee: aus → gaye
Realized we're done with this work after closing bug 1172363
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: