1173582 - no longer need to ship/load SDK CSS & related assets

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Now that we're no longer using the OpenTok CSS, we should be able to stop shipping and loading some of the assets, for slight performance gain on the standalone.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

I've got a patch; will attach.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: no longer need to ship/load SDK CSS & related assets

This causes desktop to do a failed file: URL load, and standalone to do a failed network load.  Neither of these appear to have any consequences other than a bit of wasted time and bandwidth (though presumably less than before this patch).

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Tokbox folks, would you be willing to tweak the SDK so that it can be told simply not to try and load any CSS at all?  One possible way I can imagine to do this would be simply to not do anything if window.OTProperties.cssURL is set to an empty string...

Comment 4

[msander]

(In reply to Dan Mosedale (:dmose) - needinfo? me for response from comment #3)
> Tokbox folks, would you be willing to tweak the SDK so that it can be told
> simply not to try and load any CSS at all?  One possible way I can imagine
> to do this would be simply to not do anything if window.OTProperties.cssURL
> is set to an empty string...

Yes, but I don't have an eta of when this change will be available yet.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Great; thanks!

Comment 6

[Mark Banner (:standard8)]

Bob: The proposed change here would cause each load of the Hello standalone page to attempt to load https://hello.firefox.com/shared/libs/sdk-content//css/TB.min.css which would be a 404.

Is that going to cause an issue in heka/anomaly detections, or are we safe to continue with this?

Overall, looking at the network profile, I don't think this will speed us up much until we drop the network request, but it'd still give us a bit of tidy up which would be nice.

Comment 7

[Bob Micheletto [:bobm]]

(In reply to Mark Banner (:standard8) from comment #6)

> Is that going to cause an issue in heka/anomaly detections, or are we safe
> to continue with this?

It will cause an alert after the initial deployment.  However, it should establish a new normal rate for 4xx status codes and stop alerting after that.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8621127 [details] [diff] [review]
no longer need to ship/load SDK CSS & related assets

Seems ok from an ops perspective, and doesn't seem to raise errors.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: no longer need to ship/load SDK CSS & related assets

rebased against current fx-team

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0c42f28d884d

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0c42f28d884d