Closed Bug 1173582 Opened 5 years ago Closed 5 years ago

no longer need to ship/load SDK CSS & related assets

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
Points:
1

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Iteration:
41.3 - Jun 29
Tracking Status
firefox41 --- fixed

People

(Reporter: dmose, Assigned: dmose)

Details

Attachments

(1 file, 1 obsolete file)

Now that we're no longer using the OpenTok CSS, we should be able to stop shipping and loading some of the assets, for slight performance gain on the standalone.
I've got a patch; will attach.
This causes desktop to do a failed file: URL load, and standalone to do a failed network load.  Neither of these appear to have any consequences other than a bit of wasted time and bandwidth (though presumably less than before this patch).
Attachment #8621127 - Flags: review?(standard8)
Flags: needinfo?(mozilla-support)
Tokbox folks, would you be willing to tweak the SDK so that it can be told simply not to try and load any CSS at all?  One possible way I can imagine to do this would be simply to not do anything if window.OTProperties.cssURL is set to an empty string...
Iteration: --- → 41.3 - Jun 29
Points: --- → 1
Target Milestone: --- → mozilla41
Status: NEW → ASSIGNED
Flags: firefox-backlog+
(In reply to Dan Mosedale (:dmose) - needinfo? me for response from comment #3)
> Tokbox folks, would you be willing to tweak the SDK so that it can be told
> simply not to try and load any CSS at all?  One possible way I can imagine
> to do this would be simply to not do anything if window.OTProperties.cssURL
> is set to an empty string...

Yes, but I don't have an eta of when this change will be available yet.
Great; thanks!
Bob: The proposed change here would cause each load of the Hello standalone page to attempt to load https://hello.firefox.com/shared/libs/sdk-content//css/TB.min.css which would be a 404.

Is that going to cause an issue in heka/anomaly detections, or are we safe to continue with this?

Overall, looking at the network profile, I don't think this will speed us up much until we drop the network request, but it'd still give us a bit of tidy up which would be nice.
Flags: needinfo?(mozilla-support) → needinfo?(bobm)
(In reply to Mark Banner (:standard8) from comment #6)

> Is that going to cause an issue in heka/anomaly detections, or are we safe
> to continue with this?

It will cause an alert after the initial deployment.  However, it should establish a new normal rate for 4xx status codes and stop alerting after that.
Flags: needinfo?(bobm)
Comment on attachment 8621127 [details] [diff] [review]
no longer need to ship/load SDK CSS & related assets

Seems ok from an ops perspective, and doesn't seem to raise errors.
Attachment #8621127 - Flags: review?(standard8) → review+
rebased against current fx-team
Attachment #8621127 - Attachment is obsolete: true
Attachment #8626096 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/0c42f28d884d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.