1173605 - False positive on reviewer parsing for sr= and a1.9= syntax

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Gregory Szorc [:gps]]

4cda155bcb30 (https://hg.mozilla.org/mozilla-central/rev/4cda155bcb30) has an interesting commit message:

Bug 380783 - nsStringAPI.h: no equivalent of IsVoid (tell if string is null), patch by Mook <[e-mail]>, r=bsmedberg/dbaron, sr=dbaron, a1.9=bz

If you feed that through our reviewer parser, you get:

  bsmedberg dbaron s dbaron a1 9=bz

It demonstrates some clear bugs that we should plug.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozautomation: be more strict about what constitutes reviewer syntax (bug 1173605)

mozautomation: be more strict about what constitutes reviewer syntax (bug 1173605)

There's lots of false positives in code reviewer parsing. This commit
attempts to inject some more smarts to filter out not reviewer syntax.

Comment 2

[Dan Minor [:dminor]]

Comment on attachment 8620726 [details]
MozReview Request: mozautomation: be more strict about what constitutes reviewer syntax (bug 1173605)

https://reviewboard.mozilla.org/r/10815/#review9475

Ship It!

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/ae4f313eab82

Comment 4

[Gregory Szorc [:gps]]

There's still some work to do. But running this parsing against all of mozilla-central revealed this drastically cut down on the garbage in parsed reviewer strings.