Closed Bug 1173605 Opened 6 years ago Closed 6 years ago

False positive on reviewer parsing for sr= and a1.9= syntax

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gps, Unassigned)

Details

Attachments

(1 file)

4cda155bcb30 (https://hg.mozilla.org/mozilla-central/rev/4cda155bcb30) has an interesting commit message:

Bug 380783 - nsStringAPI.h: no equivalent of IsVoid (tell if string is null), patch by Mook <mook.moz+mozbz@gmail.com>, r=bsmedberg/dbaron, sr=dbaron, a1.9=bz

If you feed that through our reviewer parser, you get:

  bsmedberg dbaron s dbaron a1 9=bz

It demonstrates some clear bugs that we should plug.
mozautomation: be more strict about what constitutes reviewer syntax (bug 1173605)

There's lots of false positives in code reviewer parsing. This commit
attempts to inject some more smarts to filter out not reviewer syntax.
Attachment #8620726 - Flags: review?(dminor)
Comment on attachment 8620726 [details]
MozReview Request: mozautomation: be more strict about what constitutes reviewer syntax (bug 1173605)

https://reviewboard.mozilla.org/r/10815/#review9475

Ship It!
Attachment #8620726 - Flags: review?(dminor) → review+
There's still some work to do. But running this parsing against all of mozilla-central revealed this drastically cut down on the garbage in parsed reviewer strings.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.