1173607 - Unlisted add-ons should not enforce unique constraint on names

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Kris Maglione [:kmag]]

We're currently enforcing the unique constraint on add-on names for unlisted add-ons, and also using the same namespace as for listed add-ons, which already rules out uploads with a large number of names.

Comment 1

[Kris Maglione [:kmag]]

Er, did not mean to submit that just yet.

Since the names for unlisted add-ons are not public, there's no reason to enforce uniqueness, or to store them as localized properties. We should store the names of unlisted add-ons in a separate char field without uniqueness constraints. A name should still, however, be required.

Comment 2

[Daniel Veditz [:dveditz]]

Just because it's not listed on the site it could very well be released to the public. Won't having different add-ons with the same name floating around confuse people? What if some scammer creates an add-on called AdBlock Plus or Downthemall and then carefully avoids doing anything that trips our automatic scans?

Our signatures enforce the uniqueness of the add-on -ID-, but we never show the ID to users so it's not useful for them to make any decisions about. And to be sure, we should NOT show the ID to the user in the installation UI because that, too, can be misleading. There's no check to prevent some using "[e-mail]" as their ID and making people think it's something official.

Comment 3

[Kris Maglione [:kmag]]

Well, as it stands, we're not enforcing name uniqueness. People can still upload an initial version of an add-on with one name, and then change the name in the install.rdf for future versions. The current constraints are for the names of listings on AMO, which don't make sense in the case of unlisted add-ons.

If we want to enforce uniqueness of add-on names as shown in the add-on manager, that's a different matter. Either way, something needs to change here.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Given that few add-ons have unique or trademarked names like AdBlock Plus and many use fairly generic names that are bound to be the same or very similar, I don't think we should have the responsibility of deciding who owns a particular name. We should absolutely chase add-ons that are trying to pretend to be others, but I think we need to deal with them case by case. We now have the files to easily identify them.

Comment 5

[Martin Kimmerle]

(In reply to Kris Maglione [:kmag] from comment #3)
> If we want to enforce uniqueness of add-on names as shown in the add-on
> manager, that's a different matter.

In any case, regardless of <em:name> in the istall manifest, the addon's name can be overridden by the localization.
See https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localizing_extension_descriptions

Comment 6

[Mike Kaply [:mkaply]]

What exactly is the check? Is it only checking against the database names in AMO?

Can I change the AMO name, do an upload and then change the name back?

This is becoming problematic for one of my clients as we have to have three versions of our add-on (AMO, non-AMO and partner repack).

I could definitely see this as being an issue for any partner builds.

Comment 7

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/636

This PR doesn't implement the "store the name of unlisted add-ons in a different, non-localized field". It simply removes the name uniqueness constraint on unlisted add-ons.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/89f4db8299555b14a8618bdebde93dd9a49af0e2
Don't enforce name uniqueness for unlisted add-ons (bug 1173607)

https://github.com/mozilla/olympia/commit/29822bd62ddc7f15b00a1e657190a1838d877ead
Merge pull request #636 from magopian/1173607-name-not-unique-for-unlisted

Don't enforce name uniqueness for unlisted add-ons (bug 1173607)

Comment 9

[Victor Carciu]

Can you please some specific STRs to this bug ?

Comment 10

[Mathieu Agopian [:magopian]]

STR:
1/ you should be able to submit an unlisted add-on that has the same name as an existing listed add-on
2/ you should be able to submit a listed add-on that has the same name as an existing unlisted add-on
3/ you should NOT be able to submit a listed add-on that has the same name as an existing listed add-on
4/ you should be able to submit an unlisted add-on that has the same name as en existing unlisted add-on

Comment 11

[Victor Carciu]

Verified as fixed for all scenarios from comment #10