1173609 - Switch unique name constraint on Addon model to unique_together on (name, type)

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Kris Maglione [:kmag]]

There's no reason to apply the unique name constraint in the same namespace across different types of add-ons. The difference between a persona and an extension with the same name is unambiguous.

We should remove the unique constraint on the name field and instead add `unique_together = ('type', 'name'),`

Comment 1

[Mathieu Agopian [:magopian]]

There's no uniqueness enforced at the database (or even model) level.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/5431c0c73d3167a7f7b51b77f8540b24d031d4cb
Addon name is only unique for a given type (bug 1173609)

https://github.com/mozilla/olympia/commit/5cf5f321675bb80a6a4c6ffa0606741bb30d64bd
Merge pull request #638 from magopian/1173609-addon-name-unique-for-type

Addon name is only unique for a given type (bug 1173609)

Comment 3

[Valentina Virlics [:vvalentina], Ecosystem QA]

Can you please add some STR to this issue so it can be properly checked? Thanks!

Comment 4

[Mathieu Agopian [:magopian]]

Forgot to add a link to the PR: https://github.com/mozilla/olympia/pull/638

Regarding the STRs: you should be able to upload a new listed extension, dictionary, search tool or theme, all using the same name. You should however not be able two of those with the same name.

This means that you can reuse the same name if there's not already an add-on of the same type (theme/dictionary/extension/search tool) with the same name.
Bug 1173607 allows several *unlisted*  add-ons to have the same name (and the same name as an existing listed add-on).

To rephrase the name uniqueness constraint only applies to listed add-ons of the same type.

Comment 5

[Valentina Virlics [:vvalentina], Ecosystem QA]

Verified as fixed on AMO-dev FF40(Win 7).
Postfix screenshots: addon-> http://screencast.com/t/KLwoRQsZ94hr dictionary-> http://screencast.com/t/HBkQc4JxDR ; search tool-> http://screencast.com/t/9kMTLldfX5 and theme-> http://screencast.com/t/M4CIoID6W6 (also the unique URL request from theme submission is not the scope of this issue)
Closing bug.