Closed Bug 1173622 Opened 4 years ago Closed 4 years ago

Add docs for mach try command

Categories

(Testing :: General, defect)

defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file)

No description provided.
Summary: Add docs for → Add docs for mach try command
I'd like to clean up the docstrings and add sphinx docs to help people understand why they would use it.
Bug 1173622 - Add a thorough docstring and clean up comments on the |mach try| command.;r=ahal
Attachment #8621278 - Flags: review?(ahalberstadt)
Assignee: nobody → cmanchester
Comment on attachment 8621278 [details]
MozReview Request: Bug 1173622 - Add a thorough docstring and clean up comments on the |mach try| command.;r=ahal

https://reviewboard.mozilla.org/r/10933/#review9625

Ship It!

::: testing/mach_commands.py:453
(Diff revision 1)
> +        The command reuires either its own mercurial extension ("push-to-try",

nit: requires

::: testing/mach_commands.py:437
(Diff revision 1)
> +        within a job by path. This will use the usual mechanism for resolving
> +        tests in mach command to determine which suites and which directories
> +        to run based on tests present in the tree. mochitests, xpcshell tests,

nit: in a mach command

Also, I don't think most people are familiar with how test resolving works, so saying "the usual mechanism" might not be all that helpful.
Attachment #8621278 - Flags: review?(ahalberstadt) → review+
https://reviewboard.mozilla.org/r/10933/#review9629

> nit: in a mach command
> 
> Also, I don't think most people are familiar with how test resolving works, so saying "the usual mechanism" might not be all that helpful.

Also capitalize 'mochitest'.
Comment on attachment 8621278 [details]
MozReview Request: Bug 1173622 - Add a thorough docstring and clean up comments on the |mach try| command.;r=ahal

Bug 1173622 - Add a thorough docstring and clean up comments on the |mach try| command.;r=ahal
Attachment #8621278 - Flags: review+
Attachment #8621278 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4be5adc1749a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.