1173642 - ARM64: Import unimplemented Ion components

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Sean Stangl [:sstangl]]

Attachment: 0001-Import-unimplemented-ARM64-Ion-components.-r.patch

This patch imports unimplemented versions of lowering and codegen for ARM64, just as little as possible to get ARM64 compiling.

This patch should be a simple r+ without requiring actual review of anything.

Marty implemented a lot of code for Ion that still exists in the arm64 branch, but it deserves a much more thorough review than is reasonable to ask for at the present; we can re-address Ion after ARM64 lands, Baseline is fixed to pass tests again, and Treeherder tests ARM64.

Comment 1

[Eric Faust [:efaust]]

Comment on attachment 8620761 [details] [diff] [review]
0001-Import-unimplemented-ARM64-Ion-components.-r.patch

Review of attachment 8620761 [details] [diff] [review]:
-----------------------------------------------------------------

sure, this is believable. Whitespace c/p d around during CodeGenerator-arm64 generation should be removed.

::: js/src/jit/arm64/CodeGenerator-arm64.cpp
@@ +96,5 @@
> +{
> +    MOZ_CRASH("bailoutFrom");
> +}
> +
> +void 

whitespace at end of line

@@ +138,5 @@
> +{
> +    MOZ_CRASH("visitSqrtD");
> +}
> +
> +void 

and here

@@ +184,5 @@
> +{
> +    MOZ_CRASH("visitAddI");
> +}
> +
> +void 

and here

@@ +203,5 @@
> +{
> +    MOZ_CRASH("visitDivI");
> +}
> +
> +void 

and here

@@ +240,5 @@
> +{
> +    MOZ_CRASH("visitBitNotI");
> +}
> +
> +void 

both this one and the function before it, after |void|

@@ +309,5 @@
> +{
> +    MOZ_CRASH("emitTableSwitchDispatch");
> +}
> +
> +void 

yuuup

@@ +444,5 @@
> +{
> +    MOZ_CRASH("visitDouble");
> +}
> +
> +void 

two again

@@ +690,5 @@
> +{
> +    MOZ_CRASH("visitUDiv");
> +}
> +
> +void 

yep

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a06337f75bb3

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a06337f75bb3