Closed Bug 1173652 Opened 5 years ago Closed 5 years ago

Merge DisplayTextLayout and ToolbarEditLayout Layout To Make Text Alignment Happen Automatically

Categories

(Firefox for Android :: Awesomescreen, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: henry, Assigned: henry, Mentored)

References

Details

The editable text shifts a bit to the right when you enter edit mode on tablet UI. Merging the two layouts will potentially fix the text shift because they will share the same layout params.
Summary: Merge DisplayTextLayout and ToolbarEditLayout Layout To Make Text Alignments Happens Automatically → Merge DisplayTextLayout and ToolbarEditLayout Layout To Make Text Alignment Happen Automatically
Assignee: nobody → henry
Make sure you take into account both phone and tablet layouts - I don't think they will come automatically because the phone layout additionally has a favicon.

Just want to state here (as I did in bug 1079182 comment 60 and later comments) that this will be difficult to do a well and may not actually be feasible to do cleanly, in so much that it negatively affects readability or efficiency, and is not worth doing.
Depends on: 1079182
This may not be worth doing due to the added code complexity and I don't think it's worth the research time to figure out.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
(In reply to Michael Comella (:mcomella) from comment #2)
> This may not be worth doing due to the added code complexity and I don't
> think it's worth the research time to figure out.

Thanks Michael for forewarning me on the possible rabbit hole this may present. In view of that, I'll go ahead and mark this ticket as `wontfix`.
Resolution: WORKSFORME → WONTFIX
You need to log in before you can comment on or make changes to this bug.