1173681 - profdirserviceprovidersa_s is mostly unused

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

So, there is this library in profile/dirserviceprovider, called profdirserviceprovidersa_s. It contains nsProfileLock.cpp and ProfileUnlockerWin.cpp, which are used in toolkit/profile, but not through the library, they're used directly:
http://hg.mozilla.org/mozilla-central/file/bfd82015df48/toolkit/profile/moz.build#l18

Now, that profdirserviceprovidersa_s library is only used by winEmbed, which is only build with xulrunner.

So here are my thoughts:
- nsProfileLock.{cpp,h} and ProfileUnlockerWin.{cpp,h} should move in toolkit/profile.
- profdirserviceprovidersa_s should use the source from toolkit/profile instead of the other way around, and only be built when winEmbed is built.
- or, instead of that second point, we kill both profdirserviceprovidersa_s and winEmbed.

Benjamin, thought?

Comment 1

[Benjamin Smedberg]

I think it's time to kill winembed and profdirservice..sa_s

Comment 2

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1173681 - Remove winEmbed

Bug 1173681 - Remove winEmbed

Comment 3

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1173681 - Don't export the ProfileUnlockerWin.h header

Bug 1173681 - Don't export the ProfileUnlockerWin.h header

Comment 4

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1173681 - Move nsProfileLock related files in toolkit/profile and remove profile/dirserviceprovider

Bug 1173681 - Move nsProfileLock related files in toolkit/profile and remove profile/dirserviceprovider

Comment 5

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1173681 - Move nsIProfileUnlocker.idl to toolkit/profile and remove profile

Bug 1173681 - Move nsIProfileUnlocker.idl to toolkit/profile and remove profile

Comment 6

[Mike Hommey [:glandium]]

Unhelpfully, both mozreview and hgweb display file moves as delete + create :( (and splinter doesn't display them at all)

Comment 7

[Benjamin Smedberg]

Comment on attachment 8621340 [details]
MozReview Request: Bug 1173681 - Remove winEmbed

https://reviewboard.mozilla.org/r/10951/#review10271

Ship It!

Comment 8

[Benjamin Smedberg]

Comment on attachment 8621341 [details]
MozReview Request: Bug 1173681 - Don't export the ProfileUnlockerWin.h header

https://reviewboard.mozilla.org/r/10953/#review10273

Ship It!

Comment 9

[Benjamin Smedberg]

Comment on attachment 8621342 [details]
MozReview Request: Bug 1173681 - Move nsProfileLock related files in toolkit/profile and remove profile/dirserviceprovider

https://reviewboard.mozilla.org/r/10955/#review10275

::: toolkit/profile/ProfileUnlockerWin.h:1
(Diff revision 1)
> +/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */

Does this match use proper hg moves? I'm still figuring out the best way to review the moves that appears as remove/add.

Comment 10

[Mike Hommey [:glandium]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #9)
> Comment on attachment 8621342 [details]
> MozReview Request: Bug 1173681 - Move nsProfileLock related files in
> toolkit/profile and remove profile/dirserviceprovider
> 
> https://reviewboard.mozilla.org/r/10955/#review10275
> 
> ::: toolkit/profile/ProfileUnlockerWin.h:1
> (Diff revision 1)
> > +/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
> 
> Does this match use proper hg moves? I'm still figuring out the best way to
> review the moves that appears as remove/add.

It does, but mozreview doesn't display them as such, hgweb on reviewboard doesn't either, and splinter doesn't either. Presently, the only way would be to hg pull the revision and look at it with hg log -p, which should display the moves.

Comment 11

[Benjamin Smedberg]

Comment on attachment 8621342 [details]
MozReview Request: Bug 1173681 - Move nsProfileLock related files in toolkit/profile and remove profile/dirserviceprovider

https://reviewboard.mozilla.org/r/10955/#review10281

Ship It!

Comment 12

[Benjamin Smedberg]

Comment on attachment 8621343 [details]
MozReview Request: Bug 1173681 - Move nsIProfileUnlocker.idl to toolkit/profile and remove profile

https://reviewboard.mozilla.org/r/10957/#review10283

Ship It!

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/391f2ca623eb
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d5feec035e2
https://hg.mozilla.org/integration/mozilla-inbound/rev/42077df6e573
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2bd296fb0f5

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/391f2ca623eb
https://hg.mozilla.org/mozilla-central/rev/2d5feec035e2
https://hg.mozilla.org/mozilla-central/rev/42077df6e573
https://hg.mozilla.org/mozilla-central/rev/f2bd296fb0f5