test_matching_text (test_toolbars.py) failing for some locales with: AssertionError: u'aa' not found in ('a', 'A')

RESOLVED FIXED in Firefox 38

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

41 Branch
mozilla41
Points:
---

Firefox Tracking Flags

(firefox38 fixed, firefox39 fixed, firefox40 fixed, firefox41 fixed, firefox-esr38 fixed)

Details

(Whiteboard: [test-failure])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The mentioned test is failing for some locales like af because the title of an auto-complete entry can contain multiple a right after each other. For the above locale it will be 'Raak'. As I have seen in those situations the letters are grouped like 'R[aa]k'. This is most likely for visibility. So an UX question.

Anyway it should work in our cases, so for the unit test we should have a search string which is unique for all locales. I feel that we should better use multiple letters here. A good solution would be 'moz' given that the default bookmarks of each locale should contain at least one bookmark related to Mozilla.
(Assignee)

Updated

3 years ago
status-firefox38: --- → affected
status-firefox39: --- → affected
status-firefox40: --- → affected
status-firefox-esr38: --- → affected
Whiteboard: [test-failure]
(Assignee)

Comment 1

3 years ago
Created attachment 8620875 [details] [review]
github_pull_request.txt

Simple fix by picking the right letters for testing the auto-complete.
Attachment #8620875 - Flags: review?(dave.hunt)
Attachment #8620875 - Flags: review?(dave.hunt) → review+
(Assignee)

Comment 2

3 years ago
Merged to master as:
https://github.com/mozilla/firefox-ui-tests/commit/ab8a405b19fdcd966ecd40e3ec42458502cd2ae3

I will backport it with possible other fixes.
status-firefox41: affected → fixed
Target Milestone: --- → Firefox 41
(Assignee)

Comment 3

3 years ago
There were no other changes lately for older branches. So I backported it now:

https://github.com/mozilla/firefox-ui-tests/commit/94ccf66fb5a572da9d0b5ae3858f3a23878db419 (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/a7542d6b24c4ba3a8fdd9af198715d2249f221fd (beta)
https://github.com/mozilla/firefox-ui-tests/commit/4d2dfc4b1b34b25af4f00fa4a6531262e68da8c0 (release)
https://github.com/mozilla/firefox-ui-tests/commit/53f8401abb3c46b76633108d8d35f622c9d73be1 (esr38)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: affected → fixed
status-firefox39: affected → fixed
status-firefox40: affected → fixed
status-firefox-esr38: affected → fixed
Resolution: --- → FIXED
(Assignee)

Comment 4

3 years ago
Interestingly we have a failure here which I do not see locally:

AssertionError: u'Moz' not found in ('moz', 'MOZ')

I think we should take the following part which landed via bug 1170148 on master:

https://github.com/mozilla/firefox-ui-tests/commit/0310d279ecb2944130a6d3e18071330ccd589da2#diff-c2e9f8f39b26c9732df8467db2d53b1bR143

This only affects aurora and lower.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.