Unhovered+inactive tab close icon broken on non-100%-DPI brighttext TabsToolbar (e.g. lw themes, win7/winxp classic, winxp luna blue)

VERIFIED FIXED in Firefox 40

Status

()

Firefox
Theme
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

({regression})

Trunk
Firefox 41
regression
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox39 unaffected, firefox40+ verified, firefox41 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Created attachment 8620892 [details]
tabclose.PNG

Presumably caused by bug 1168528.
(Assignee)

Updated

3 years ago
Summary: Unhovered/active tab close icon broken on non-100%-DPI win7 → Unhovered/active tab close icon broken on non-100%-DPI win7 classic (works on aero and aero basic)
(Assignee)

Comment 1

3 years ago
#TabsToolbar[brighttext] .tab-close-button:not(:hover):not([visuallyselected="true"]) {
  -moz-image-region: rect(0, 64px, 16px, 48px) !important;
}

is the offending rule, which sets the icon to the inverted range in the non-hidpi image. We need to make this rule lodpi-only and add one for hidpi.
(Assignee)

Updated

3 years ago
Summary: Unhovered/active tab close icon broken on non-100%-DPI win7 classic (works on aero and aero basic) → Unhovered/active tab close icon broken on non-100%-DPI brighttext TabsToolbar (e.g. lw themes, win7/winxp classic, winxp luna blue)
(Assignee)

Updated

3 years ago
Summary: Unhovered/active tab close icon broken on non-100%-DPI brighttext TabsToolbar (e.g. lw themes, win7/winxp classic, winxp luna blue) → Unhovered+inactive tab close icon broken on non-100%-DPI brighttext TabsToolbar (e.g. lw themes, win7/winxp classic, winxp luna blue)
(Assignee)

Comment 2

3 years ago
Created attachment 8620903 [details]
MozReview Request: Bug 1173711 - fix unhovered/inactive hidpi close icons, r?jaws

Bug 1173711 - fix unhovered/inactive hidpi close icons, r?jaws
Attachment #8620903 - Flags: review?(jaws)
Attachment #8620903 - Flags: review?(jaws) → review+
Comment on attachment 8620903 [details]
MozReview Request: Bug 1173711 - fix unhovered/inactive hidpi close icons, r?jaws

https://reviewboard.mozilla.org/r/10867/#review9507

Ship It!
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/c2570d3a3e4a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
(Assignee)

Comment 6

3 years ago
Comment on attachment 8620903 [details]
MozReview Request: Bug 1173711 - fix unhovered/inactive hidpi close icons, r?jaws

Approval Request Comment
[Feature/regressing bug #]: bug 1168528 which got uplifted to 40
[User impact if declined]: broken icons on hidpi high-contrast/classic themes across Windows
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: low, css only
[String/UUID change made/needed]: no
Attachment #8620903 - Flags: approval-mozilla-beta?
Tracking this regression.
status-firefox39: --- → unaffected
status-firefox40: --- → affected
tracking-firefox40: --- → +
Comment on attachment 8620903 [details]
MozReview Request: Bug 1173711 - fix unhovered/inactive hidpi close icons, r?jaws

This patch has been in 41 for a good while now. It is a regression introduced in 40. The change is also straightforward. Let's get this into beta5. Beta+
Attachment #8620903 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
I was able to reproduce this issue on Firefox 42.0a1 (2015-06-11) under Windows 7 64-bit.

Verified fixed on Firefox 41.0a2 (2015-07-29) and Firefox 40 Beta 8 (20150727174134) under Windows 7 64-bit and Windows XP 64-bit.
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
status-firefox41: fixed → verified
You need to log in before you can comment on or make changes to this bug.