1173712 - Updates should clear the searchplugins folder in the application directory

Status: RESOLVED INVALID

(Toolkit :: Application Update, defect)

Description

[Florian Quèze [:florian]]

http://mxr.mozilla.org/mozilla-central/source/browser/installer/removed-files.in#125 contains:
@DIR_MACOS@searchplugins/*
which I think should clear the searchplugins folder during updates, but apparently it doesn't; do you know why?

Context:

(Petruta Rasa [QA] [:petruta] from bug 1162569 comment #24)

> *Win: the Nightly build that I frequently use and update still has the
> "searchplugins" folder and it contains the mdew.xml file (attached)

(:Gavin Sharp from bug 1162569 comment #27)
> (In reply to Florian Quèze [:florian] [:flo] from comment #25)
> > This is a little bit unfortunate, but I don't think it will cause any issue
> > for users. I guess the removed-files (especially
> > http://mxr.mozilla.org/mozilla-central/source/browser/installer/removed-
> > files.in#125) is now only taken into account when re-installing using the
> > install wizard.
> 
> This shouldn't be the case, and the behavior Petruta describes shouldn't
> happen (updates should clear the folder). Can you follow up with
> nthomas/rstrong about this?

Comment 1

[Robert Strong (they/them - no direct email)]

Possibly due to not having permissions to remove the file. The fact that there is only one file in that directory implies the ones distributed with the app were removed. Is this a non-Mozilla distributed search plugin?

Comment 2

[Robert Strong (they/them - no direct email)]

For comment #1

Comment 3

[Florian Quèze [:florian]]

mdew.xml / attachment 8614679 [details] doesn't look like an engine we ship.

Petruta, if you still have this file, you could please check if there's anything special with its permissions that could prevent our updater from removing it? Is it a file you added yourself at some point to test something, or a file that has been added there by some other software?

Comment 4

[Robert Strong (they/them - no direct email)]

It would also be helpful to get the last-update.log and backup-update.log from the system.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

I don't have anything to add.

Comment 6

[Petruta Horea [:phorea], Desktop QA]

Attachment: backup-update.log

Comment 7

[Petruta Horea [:phorea], Desktop QA]

Attachment: last-update.log

I will search to see if that file (mdew.html) is something I was working on. I didn't found anything yet, but I remember seeing prov.testsite.nz somewhere, wasn't it added as search engine to Nightly builds some time ago?

Comment 8

[Robert Strong (they/them - no direct email)]

(In reply to Petruta Rasa [QA] [:petruta] from comment #7)
> Created attachment 8625456 [details]
> last-update.log
> 
> I will search to see if that file (mdew.html) is something I was working on.
That should be mdew.xml

Comment 9

[Robert Strong (they/them - no direct email)]

Comment on attachment 8625455 [details]
backup-update.log

These log files appear to be from after this was fixed on the affected system. Is that the case?

Comment 10

[Petruta Horea [:phorea], Desktop QA]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #8)
> That should be mdew.xml
Right, sorry.

> These log files appear to be from after this was fixed on the affected
> system. Is that the case?
I update the Nightly build almost daily, those files were modified today.

Comment 11

[Robert Strong (they/them - no direct email)]

Please reproduce again as you did in bug 1162569, include the steps you used, and then attach those two logs.

Comment 12

[Petruta Horea [:phorea], Desktop QA]

I couldn't find how mdew.xml file ended up in searchplugins folder for that particular Nightly build.

There's no steps to reproduce, the file is there and I found it while verifying bug 1162569 with an existing Nightly build. So I can't replicate again and I suppose those two logs would have been useful when I first encountered this. 

When I installed a build from ftp, the searchplugins folder wasn't there, as expected.
I also tried with a Nightly 33.0a1 build from 2014-06-11 that was installed on my machine and had searchplugins folder. After updating it with the About option, the searchplugins folder was removed (as expected).

Comment 13

[Robert Strong (they/them - no direct email)]

For files that aren't part of our build we do best effort to try to remove them which works most of the time. For Mac bug 394984 will make this much better. Resolving -> invalid.