Closed
Bug 1173734
Opened 9 years ago
Closed 9 years ago
Make the separator for the menu / hamburger button (more) solid
Categories
(Firefox :: Theme, defect, P2)
Tracking
()
VERIFIED
FIXED
Firefox 42
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(2 files, 1 obsolete file)
7.95 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
7.78 KB,
patch
|
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
No description provided.
Comment 1•9 years ago
|
||
We've tried doing this repeatedly, but we always ran into how clumsy this looks if the bookmarks toolbar is open. Has that changed? (None of the mockups show the bookmarks toolbar...)
Flags: needinfo?(shorlander)
Comment 2•9 years ago
|
||
I had a visual solution for that, but it would have required adding a way to know when the bookmarks menu was open I think? In this case I purposely left some top/bottom margin on the separator and I think it works ok in Windows 10 context where there is a lot of flat blockiness already.
Flags: needinfo?(shorlander)
Comment 3•9 years ago
|
||
Oops, forgot to link solution I was talking about: http://cl.ly/image/0D3x143b3c0c
Updated•9 years ago
|
Priority: -- → P1
Updated•9 years ago
|
Priority: P1 → P2
Comment 4•9 years ago
|
||
We can simply use the same style as DevEdition for both Windows 8 and 10. Also addresses comment #1's concern.
Updated•9 years ago
|
No longer blocks: windows-10
Assignee | ||
Updated•9 years ago
|
QA Contact: dao
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dao
QA Contact: dao
Assignee | ||
Comment 5•9 years ago
|
||
This is kind of a compromise, making the separator more flat but not quite, to mitigate the bookmarks toolbar issue. This also means we can just make this change across the board.
Attachment #8637903 -
Flags: review?(jaws)
Assignee | ||
Comment 6•9 years ago
|
||
oops
Attachment #8637903 -
Attachment is obsolete: true
Attachment #8637903 -
Flags: review?(jaws)
Attachment #8637904 -
Flags: review?(jaws)
Updated•9 years ago
|
Attachment #8637904 -
Flags: review?(jaws) → review+
Assignee | ||
Updated•9 years ago
|
OS: Windows 10 → All
Summary: Use solid separator for the menu / hamburger button on Windows 10 → Make the separator for the menu / hamburger button (more) solid
Assignee | ||
Updated•9 years ago
|
Flags: qe-verify+
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/35c63a219caf
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Assignee | ||
Comment 10•9 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: Windows 10 [User impact if declined]: just aesthetics [Describe test coverage new/current, TreeHerder]: n/a [Risks and why]: CSS-only patch, not most trivial but still straightforward, low risk [String/UUID change made/needed]: none
Attachment #8639400 -
Flags: approval-mozilla-beta?
Attachment #8639400 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox40:
--- → affected
Comment 11•9 years ago
|
||
Comment on attachment 8639400 [details] [diff] [review] branch patch Theme change for Windows 10 that has been on m-c for 3 days. Let's verify this fix in beta8. Beta+ Aurora+
Attachment #8639400 -
Flags: approval-mozilla-beta?
Attachment #8639400 -
Flags: approval-mozilla-beta+
Attachment #8639400 -
Flags: approval-mozilla-aurora?
Attachment #8639400 -
Flags: approval-mozilla-aurora+
Comment 14•9 years ago
|
||
I am not quite sure which is the intended style here for the hamburger separator, because it does not look like the solution from Comment 3 ( http://cl.ly/image/0D3x143b3c0c ) and neither like in DevEdition version from 2015-07-22 as it was mentioned in Comment 4 ( http://i.imgur.com/doAWXEL.jpg ). Tested on Firefox 42.0a1 (2015-07-29), Firefox 41.0a2 (2015-07-29) and Firefox 40 Beta 8 (20150727174134) under Windows 10 64-bit and Windows 8 32-bit. The hamburger separator actually appears as in the following example: http://i.imgur.com/M2JuLW1.jpg Is this the intended design?
Flags: needinfo?(dao)
Assignee | ||
Comment 15•9 years ago
|
||
(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #14) > Is this the intended design? for now, yes
Flags: needinfo?(dao)
Comment 16•9 years ago
|
||
I am marking this bug as Verified, based on Comment 14 and Comment 15.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•