Closed Bug 1173734 Opened 9 years ago Closed 9 years ago

Make the separator for the menu / hamburger button (more) solid

Categories

(Firefox :: Theme, defect, P2)

Unspecified
All
defect

Tracking

()

VERIFIED FIXED
Firefox 42
Tracking Status
firefox40 --- verified
firefox41 --- verified
firefox42 --- verified

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(2 files, 1 obsolete file)

      No description provided.
We've tried doing this repeatedly, but we always ran into how clumsy this looks if the bookmarks toolbar is open. Has that changed? (None of the mockups show the bookmarks toolbar...)
Flags: needinfo?(shorlander)
I had a visual solution for that, but it would have required adding a way to know when the bookmarks menu was open I think?

In this case I purposely left some top/bottom margin on the separator and I think it works ok in Windows 10 context where there is a lot of flat blockiness already.
Flags: needinfo?(shorlander)
Oops, forgot to link solution I was talking about: http://cl.ly/image/0D3x143b3c0c
Priority: -- → P1
Priority: P1 → P2
We can simply use the same style as DevEdition for both Windows 8 and 10. Also addresses comment #1's concern.
No longer blocks: windows-10
QA Contact: dao
Assignee: nobody → dao
QA Contact: dao
Attached patch patch (obsolete) — Splinter Review
This is kind of a compromise, making the separator more flat but not quite, to mitigate the bookmarks toolbar issue. This also means we can just make this change across the board.
Attachment #8637903 - Flags: review?(jaws)
Attached patch patchSplinter Review
oops
Attachment #8637903 - Attachment is obsolete: true
Attachment #8637903 - Flags: review?(jaws)
Attachment #8637904 - Flags: review?(jaws)
Attachment #8637904 - Flags: review?(jaws) → review+
OS: Windows 10 → All
Summary: Use solid separator for the menu / hamburger button on Windows 10 → Make the separator for the menu / hamburger button (more) solid
Flags: qe-verify+
https://hg.mozilla.org/mozilla-central/rev/35c63a219caf
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Attached patch branch patchSplinter Review
Approval Request Comment
[Feature/regressing bug #]: Windows 10
[User impact if declined]: just aesthetics
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: CSS-only patch, not most trivial but still straightforward, low risk
[String/UUID change made/needed]: none
Attachment #8639400 - Flags: approval-mozilla-beta?
Attachment #8639400 - Flags: approval-mozilla-aurora?
Comment on attachment 8639400 [details] [diff] [review]
branch patch

Theme change for Windows 10 that has been on m-c for 3 days. Let's verify this fix in beta8. Beta+ Aurora+
Attachment #8639400 - Flags: approval-mozilla-beta?
Attachment #8639400 - Flags: approval-mozilla-beta+
Attachment #8639400 - Flags: approval-mozilla-aurora?
Attachment #8639400 - Flags: approval-mozilla-aurora+
I am not quite sure which is the intended style here for the hamburger separator, because it does not look like the solution from Comment 3 ( http://cl.ly/image/0D3x143b3c0c ) and neither like in DevEdition version from 2015-07-22 as it was mentioned in Comment 4 ( http://i.imgur.com/doAWXEL.jpg ).

Tested on Firefox 42.0a1 (2015-07-29), Firefox 41.0a2 (2015-07-29) and Firefox 40 Beta 8 (20150727174134) under Windows 10 64-bit and Windows 8 32-bit.


The hamburger separator actually appears as in the following example: http://i.imgur.com/M2JuLW1.jpg

Is this the intended design?
Flags: needinfo?(dao)
(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #14)
> Is this the intended design?

for now, yes
Flags: needinfo?(dao)
I am marking this bug as Verified, based on Comment 14 and Comment 15.
You need to log in before you can comment on or make changes to this bug.