Closed Bug 1173740 Opened 5 years ago Closed 4 years ago

Update switch-to-tab icon for the URL bar autocomplete popup on Windows 8 and 10

Categories

(Firefox :: Theme, defect, P3)

Unspecified
Windows 10
defect

Tracking

()

VERIFIED FIXED
Firefox 42
Tracking Status
firefox39 --- unaffected
firefox40 --- verified
firefox41 --- verified
firefox42 --- verified

People

(Reporter: dao, Assigned: dao)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

No description provided.
needinfo for the icon
Flags: needinfo?(shorlander)
This is only a minor icon update in a not particularly prominent place in the UI; seems like a lower priority fix by definition.
Priority: P1 → P3
Attachment #8630539 - Attachment description: actionicon-tab.png → actionicon-tab-win10.png
Attachment #8630539 - Attachment filename: actionicon-tab.png → actionicon-tab-win10.png
Assignee: nobody → dao
Attached patch patchSplinter Review
Attachment #8636625 - Flags: review?(jaws)
Comment on attachment 8636625 [details] [diff] [review]
patch

Review of attachment 8636625 [details] [diff] [review]:
-----------------------------------------------------------------

actionicon-tab.png should have been renamed to actionicon-tab-XPVista7.png, and then the updated actionicon-tab.png should have been created. As it is right now, the hg history of this file isn't going to match the real history of the file.
Attachment #8636625 - Flags: review?(jaws) → review+
Flags: qe-verify+
Summary: Update switch-to-tab icon for the URL bar autocomplete popup on Windows 10 → Update switch-to-tab icon for the URL bar autocomplete popup on Windows 8 and 10
https://hg.mozilla.org/mozilla-central/rev/16b45b87b55d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8636625 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: windows 10
[User impact if declined]: aesthetics
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: straightforward CSS patch, low risk
[String/UUID change made/needed]: none
Attachment #8636625 - Flags: approval-mozilla-beta?
Attachment #8636625 - Flags: approval-mozilla-aurora?
Comment on attachment 8636625 [details] [diff] [review]
patch

As per the bug summary, this change does impact Windows 8 as well. We should verify the change on both Win8 and Win10. Beta+ Aurora+
Attachment #8636625 - Flags: approval-mozilla-beta?
Attachment #8636625 - Flags: approval-mozilla-beta+
Attachment #8636625 - Flags: approval-mozilla-aurora?
Attachment #8636625 - Flags: approval-mozilla-aurora+
QA Contact: cornel.ionce
Reproduced this issue with Firefox 40 beta 6.

Confirming the fix on WIndows 8.1 32-bit and Windows 10 64-bit using:
- latest Nightly, build ID: 20150723030207;
- latest Aurora, build ID: 20150723004007;
- Firefox 40 beta 7, build ID: 20150723165742.
Also verified using a Microsoft Surface Pro 2 device.
You need to log in before you can comment on or make changes to this bug.